Allow direct executors in cronet.

components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.impl;
 
 import android.util.Log;
 
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
@@ skipping 288 matching lines @@
         }
     }
 
     /**
      * Initializes upload length by getting it from data provider. Always called
      * on executor thread to allow getLength() to block and/or report errors.
      * If data provider throws an exception, then it is reported to the request.
      * No native calls to urlRequest are allowed as this is done before request
      * start, so native object may not exist.
      */
-    void initializeWithRequest(final CronetUrlRequest urlRequest) {
+    void initializeWithRequest(final CronetUrlRequest urlRequest, final Runnable callback) {
         synchronized (mLock) {
             mRequest = urlRequest;
-            mInWhichUserCallback = UserCallback.GET_LENGTH;
         }
-        try {
-            mLength = mDataProvider.getLength();
-            mRemainingLength = mLength;
-        } catch (Throwable t) {
-            onError(t);
-        }
-        synchronized (mLock) {
-            mInWhichUserCallback = UserCallback.NOT_IN_CALLBACK;
-        }
+        postTaskToExecutor(new Runnable() {

[mef, 2016/08/30 16:29:45]

this is already on executor thread, why do you need to post?

[Charles, 2016/08/30 20:11:06]

It's not on the executor thread any more.

[mef, 2016/08/31 17:26:52]

Acknowledged. Please update comment.

[Charles, 2016/08/31 19:08:36]

Done.

+            @Override
+            public void run() {
+                synchronized (mLock) {
+                    mInWhichUserCallback = UserCallback.GET_LENGTH;
+                }
+                try {
+                    mLength = mDataProvider.getLength();
+                    mRemainingLength = mLength;
+                } catch (Throwable t) {
+                    onError(t);
+                }
+                synchronized (mLock) {
+                    mInWhichUserCallback = UserCallback.NOT_IN_CALLBACK;
+                }
+                callback.run();
+            }
+        });
     }
 
     /**
      * Creates native objects and attaches them to the underlying request
      * adapter object. Always called on executor thread.
      */
     void attachNativeAdapterToRequest(final long requestAdapter) {
         synchronized (mLock) {
             mUploadDataStreamAdapter = nativeAttachUploadDataToRequest(requestAdapter, mLength);
         }
@@ skipping 29 matching lines @@
 
     @NativeClassQualifiedName("CronetUploadDataStreamAdapter")
     private native void nativeOnReadSucceeded(long nativePtr, int bytesRead, boolean finalChunk);
 
     @NativeClassQualifiedName("CronetUploadDataStreamAdapter")
     private native void nativeOnRewindSucceeded(long nativePtr);
 
     @NativeClassQualifiedName("CronetUploadDataStreamAdapter")
     private static native void nativeDestroy(long nativePtr);
 }