Allow direct executors in cronet.

components/cronet/android/api/src/org/chromium/net/CronetEngine.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.annotation.SuppressLint;
 import android.content.Context;
 import android.net.http.HttpResponseCache;
 import android.support.annotation.IntDef;
@@ skipping 809 matching lines @@
      *         {@link UrlRequest.Builder#REQUEST_PRIORITY_IDLE REQUEST_PRIORITY_*}
      *         values.
      * @return new request.
      * @deprecated Use {@link UrlRequest.Builder#build}.
      * @hide
      */
     @Deprecated
     public final UrlRequest createRequest(String url, UrlRequest.Callback callback,
             Executor executor, @UrlRequest.Builder.RequestPriority int priority) {
         return createRequest(
-                url, callback, executor, priority, Collections.emptyList(), false, false);
+                url, callback, executor, priority, Collections.emptyList(), false, false, false);
     }
 
     /**
      * Creates a {@link UrlRequest} object. All callbacks will
      * be called on {@code executor}'s thread. {@code executor} must not run
      * tasks on the current thread to prevent blocking networking operations
      * and causing exceptions during shutdown.
      *
      * @param url {@link URL} for the request.
      * @param callback callback object that gets invoked on different events.
      * @param executor {@link Executor} on which all callbacks will be invoked.
      * @param priority priority of the request which should be one of the
      *         {@link UrlRequest.Builder#REQUEST_PRIORITY_IDLE REQUEST_PRIORITY_*}
      *         values.
      * @param requestAnnotations Objects to pass on to {@link RequestFinishedInfo.Listener}.
      * @param disableCache disables cache for the request.
      *         If context is not set up to use cache this param has no effect.
      * @param disableConnectionMigration disables connection migration for this
      *         request if it is enabled for the session.
+     * @param allowDirectExecutor whether executors used by this request are permitted
+     *         to execute submitted tasks inline.
      * @return new request.
      * @deprecated Use {@link UrlRequest.Builder#build}.
      * @hide as it references hidden RequestFinishedInfo.Listener
      */
     @Deprecated
     protected abstract UrlRequest createRequest(String url, UrlRequest.Callback callback,
             Executor executor, int priority, Collection<Object> requestAnnotations,
-            boolean disableCache, boolean disableConnectionMigration);
+            boolean disableCache, boolean disableConnectionMigration, boolean allowDirectExecutor);

[mef, 2016/08/30 16:29:44]

G'Ah. This will break all the HackMockCronetEngines that override this. :(

[Charles, 2016/08/30 20:11:05]

Acknowledged.

 
     /**
      * Creates a {@link BidirectionalStream} object. {@code callback} methods will
      * be invoked on {@code executor}. {@code executor} must not run
      * tasks on the current thread to prevent blocking networking operations
      * and causing exceptions during shutdown.
      *
      * @param url the URL for the stream
      * @param callback the object whose methods get invoked upon different events
      * @param executor the {@link Executor} on which all callbacks will be called
@@ skipping 277 matching lines @@
 
     /**
      * Removes a finished request listener.
      *
      * @param listener the listener to remove.
      *
      * @hide it's a prototype.
      */
     public abstract void removeRequestFinishedListener(RequestFinishedInfo.Listener listener);
 }