Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 228323007: Remove color-profile from SVG (Closed)

Created:
6 years, 8 months ago by rwlbuis
Modified:
6 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, ed+blinkwatch_opera.com, kouhei+svg_chromium.org, fs, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, gyuyoung.kim_webkit.org, darktears, f(malita), Stephen Chennney, rune+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove color-profile from SVG color-profile is removed from SVG2 and we never got to implementing it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171681

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Fix one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M LayoutTests/fast/dom/custom/element-names.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/SVGCSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/SVGCSSPropertyNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/custom/CustomElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
PTAL
6 years, 8 months ago (2014-04-15 15:51:54 UTC) #1
pdr.
On 2014/04/15 15:51:54, rwlbuis wrote: > PTAL LGTM
6 years, 8 months ago (2014-04-15 18:37:08 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 8 months ago (2014-04-15 18:37:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/228323007/40001
6 years, 8 months ago (2014-04-15 18:37:25 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 19:40:53 UTC) #5
Message was sent while issue was closed.
Change committed as 171681

Powered by Google App Engine
This is Rietveld 408576698