tracing/tracing/metrics/system_health/long_tasks_metric.html - Issue 2283213002: Rename Histogram.add() to addSample().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/long_tasks_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/metrics/system_health/long_tasks_metric.html

diff --git a/tracing/tracing/metrics/system_health/long_tasks_metric.html b/tracing/tracing/metrics/system_health/long_tasks_metric.html

index d12818d50d6f1cbf53b5b779de00cc74ad388d19..5b4000028c9431baa692ffc39725f592521153a4 100644

--- a/tracing/tracing/metrics/system_health/long_tasks_metric.html

+++ b/tracing/tracing/metrics/system_health/long_tasks_metric.html

@@ -82,8 +82,8 @@ tr.exportTo('tr.metrics.sh', function() {

iterateRendererMainThreads(model, function(thread) {

iterateLongTopLevelTasksOnThreadInRange(

thread, rangeOfInterest, function(task) {

- longTaskNumeric.add(task.duration, tr.v.d.DiagnosticMap.fromObject({

- relatedEvents: new tr.v.d.RelatedEventSet([task])}));

+ longTaskNumeric.addSample(task.duration,

+ {relatedEvents: new tr.v.d.RelatedEventSet([task])});

slices.push(task);

slices.addEventSet(task.descendentSlices);

});