tracing/tracing/metrics/cpu_process_metric.html - Issue 2283213002: Rename Histogram.add() to addSample(). - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(289)

My Issues | Starred Open | Closed | All

Unified Diff: tracing/tracing/metrics/cpu_process_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « tracing/tracing/metrics/blink/gc_metric.html ('k') | tracing/tracing/metrics/metric_registry_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/cpu_process_metric.html

diff --git a/tracing/tracing/metrics/cpu_process_metric.html b/tracing/tracing/metrics/cpu_process_metric.html

index 8f0420117a4c92a8cdd92737b9ceefec2c966780..e570367269edf1c754bd4dd45c81c71dee3c0b5f 100644

--- a/tracing/tracing/metrics/cpu_process_metric.html

+++ b/tracing/tracing/metrics/cpu_process_metric.html

@@ -53,7 +53,7 @@ tr.exportTo('tr.metrics.sh', function() {

paths: new Set()

});

}

- processNumerics.get(processName).numeric.add(

+ processNumerics.get(processName).numeric.addSample(

processData.sum / 100.0);

for (var path of processData.paths)

processNumerics.get(processName).paths.add(path);

@@ -72,7 +72,7 @@ tr.exportTo('tr.metrics.sh', function() {

// taken.

var missingSnapshotCount = snapshots.length - numeric.numValues;

for (var i = 0; i < missingSnapshotCount; i++)

- numeric.add(0);

+ numeric.addSample(0);

var value = new tr.v.NumericValue('cpu:percent:' + processName, numeric);

value.diagnostics.set('paths', new

tr.v.d.Generic([...processData.paths]));

« no previous file with comments | « tracing/tracing/metrics/blink/gc_metric.html ('k') | tracing/tracing/metrics/metric_registry_test.html » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698