Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2283203003: Implement simple http server with set cookie functionality. (Closed)

Created:
4 years, 3 months ago by liaoyuke
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement simple http server with set cookie functionality. Add functionality to http server utility so that it can include Set-Coockie in the header. Some tests need cookies to be set, sets cookie through http response can better simulate real world user behavior than through javascript. BUG= Committed: https://crrev.com/f4eee1cd7196932caa0261c4fed6723242d4d4a8 Cr-Commit-Position: refs/heads/master@{#415322}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M ios/web/public/test/http_server_util.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/web/public/test/http_server_util.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/web/public/test/response_providers/html_response_provider.h View 1 chunk +4 lines, -0 lines 2 comments Download
M ios/web/public/test/response_providers/html_response_provider.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/web/public/test/response_providers/html_response_provider_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M ios/web/public/test/response_providers/html_response_provider_impl.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/web/public/test/response_providers/response_provider.h View 1 chunk +4 lines, -0 lines 2 comments Download
M ios/web/public/test/response_providers/response_provider.mm View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
liaoyuke
I created some tests locally to verify that the functionality does set cookies.
4 years, 3 months ago (2016-08-27 00:17:27 UTC) #4
baxley
lgtm
4 years, 3 months ago (2016-08-30 15:52:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283203003/1
4 years, 3 months ago (2016-08-30 16:06:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 16:52:31 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f4eee1cd7196932caa0261c4fed6723242d4d4a8 Cr-Commit-Position: refs/heads/master@{#415322}
4 years, 3 months ago (2016-08-30 16:54:52 UTC) #12
pkl (ping after 24h if needed)
https://codereview.chromium.org/2283203003/diff/1/ios/web/public/test/response_providers/html_response_provider.h File ios/web/public/test/response_providers/html_response_provider.h (right): https://codereview.chromium.org/2283203003/diff/1/ios/web/public/test/response_providers/html_response_provider.h#newcode32 ios/web/public/test/response_providers/html_response_provider.h:32: const std::string& cookie); I don't think "explicit" on a ...
4 years, 3 months ago (2016-08-30 21:24:04 UTC) #14
liaoyuke
4 years, 3 months ago (2016-09-12 18:58:13 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2283203003/diff/1/ios/web/public/test/respons...
File ios/web/public/test/response_providers/html_response_provider.h (right):

https://codereview.chromium.org/2283203003/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/html_response_provider.h:32: const
std::string& cookie);
On 2016/08/30 21:24:04, pklpkl wrote:
> I don't think "explicit" on a constructor w/ more than 1 parameter means
> anything. Do you?
> See HtmlResponseProviderImpl as well.

Done.

https://codereview.chromium.org/2283203003/diff/1/ios/web/public/test/respons...
File ios/web/public/test/response_providers/response_provider.h (right):

https://codereview.chromium.org/2283203003/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/response_provider.h:57: // response code.
On 2016/08/30 21:24:04, pklpkl wrote:
> This comment does not match what this method actually does. It should describe
> what it does with |cookie|.

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698