Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2283193002: Disable EME playback tests when using mojo cdm/renderer. (Closed)

Created:
4 years, 3 months ago by alokp
Modified:
4 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable EME playback tests when using mojo cdm/renderer. BUG=641559 Committed: https://crrev.com/5a465d6e732dbe747db2c88507c84febe993f25d Cr-Commit-Position: refs/heads/master@{#414865}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/browser/media/encrypted_media_browsertest.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
alokp
4 years, 3 months ago (2016-08-26 22:47:14 UTC) #2
xhwang
https://codereview.chromium.org/2283193002/diff/1/content/browser/media/encrypted_media_browsertest.cc File content/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/2283193002/diff/1/content/browser/media/encrypted_media_browsertest.cc#newcode18 content/browser/media/encrypted_media_browsertest.cc:18: #if defined(ENABLE_MOJO_CDM) || defined(ENABLE_MOJO_RENDERER) Just use defined(ENABLE_MOJO_RENDERER). Using MojoCdm ...
4 years, 3 months ago (2016-08-26 22:56:46 UTC) #3
alokp
https://codereview.chromium.org/2283193002/diff/1/content/browser/media/encrypted_media_browsertest.cc File content/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/2283193002/diff/1/content/browser/media/encrypted_media_browsertest.cc#newcode18 content/browser/media/encrypted_media_browsertest.cc:18: #if defined(ENABLE_MOJO_CDM) || defined(ENABLE_MOJO_RENDERER) On 2016/08/26 22:56:45, xhwang (slow) ...
4 years, 3 months ago (2016-08-26 23:05:53 UTC) #4
xhwang
lgtm
4 years, 3 months ago (2016-08-26 23:11:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283193002/20001
4 years, 3 months ago (2016-08-26 23:12:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 23:57:02 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 23:59:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a465d6e732dbe747db2c88507c84febe993f25d
Cr-Commit-Position: refs/heads/master@{#414865}

Powered by Google App Engine
This is Rietveld 408576698