Disable WebRTC CaptureFromMediaElement test when using mojo renderer.

Disable WebRTC CaptureFromMediaElement test when using mojo renderer.

BUG=641559
Committed: https://crrev.com/cacc2c351d60d27969aa4044ae0aa248a1a2eab8
Cr-Commit-Position: refs/heads/master@{#415362}

[alokp, 2016-08-26 22:16:07]

alokp@chromium.org changed reviewers:
+ phoglund@chromium.org, xhwang@chromium.org

[xhwang, 2016-08-26 22:29:13]

Looking good to me. You'll need a webrtc owner to stamp it.

[alokp, 2016-08-29 17:09:58]

Description was changed from

==========
Disable WebRTC CaptureFromMediaElement test when using mojo renderer.

BUG=641559
==========

to

==========
Disable WebRTC CaptureFromMediaElement test when using mojo renderer.

BUG=641559
==========

[alokp, 2016-08-29 17:09:58]

alokp@chromium.org changed reviewers:
+ perkj@chromium.org

[alokp, 2016-08-29 17:10:25]

+perkj@ in case phoglund@ is OOO

[perkj_chrome, 2016-08-30 07:17:36]

lgtm

[alokp, 2016-08-30 17:36:31]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:37:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:26:01]

Description was changed from

==========
Disable WebRTC CaptureFromMediaElement test when using mojo renderer.

BUG=641559
==========

to

==========
Disable WebRTC CaptureFromMediaElement test when using mojo renderer.

BUG=641559
==========

[commit-bot: I haz the power, 2016-08-30 18:26:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-30 18:29:31]

Description was changed from

==========
Disable WebRTC CaptureFromMediaElement test when using mojo renderer.

BUG=641559
==========

to

==========
Disable WebRTC CaptureFromMediaElement test when using mojo renderer.

BUG=641559

Committed: https://crrev.com/cacc2c351d60d27969aa4044ae0aa248a1a2eab8
Cr-Commit-Position: refs/heads/master@{#415362}
==========

[commit-bot: I haz the power, 2016-08-30 18:29:32]

Patchset 1 (id:??) landed as
https://crrev.com/cacc2c351d60d27969aa4044ae0aa248a1a2eab8
Cr-Commit-Position: refs/heads/master@{#415362}

[mcasas, 2016-08-30 19:09:07]

mcasas@chromium.org changed reviewers:
+ mcasas@chromium.org

[mcasas, 2016-08-30 19:09:07]

This was not done according to Chrome
styleguide... :(

https://codereview.chromium.org/2283163002/diff/1/content/browser/webrtc/webr...
File content/browser/webrtc/webrtc_capture_from_element_browsertest.cc (right):

https://codereview.chromium.org/2283163002/diff/1/content/browser/webrtc/webr...
content/browser/webrtc/webrtc_capture_from_element_browsertest.cc:13: // process
and hence does not support capture: crbug.com/641559.
This should be https://crbug.com/641559

https://codereview.chromium.org/2283163002/diff/1/content/browser/webrtc/webr...
content/browser/webrtc/webrtc_capture_from_element_browsertest.cc:21: #if
!defined(DISABLE_CAPTURE_FROM_MEDIA_ELEMENT_TESTS)
This is not how tests are disabled. It should be

#if defined(ENABLE_MOJO_RENDERER)
// Comments...
#define MAYBE_CaptureFromMediaElement DISABLED_CaptureFromMediaElement
#else
#define MAYBE_CaptureFromMediaElement CaptureFromMediaElement
#endif  

And then rename the test in l.72 to MAYBE_CaptureFromMediaElement

[alokp, 2016-08-30 19:14:27]

mcasas: Thanks for your comments. Let me send another patch to address them.