Issue 2283153002: Cherrypick Bugfix for cross-origin check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2283153002: Cherrypick Bugfix for cross-origin check (Closed)

Created:
4 years, 3 months ago by hubbe

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Cherrypick Bugfix for cross-origin check The code is mistaking a missing reader for an error, but readers are now destroyed and re-created on demand. Adding a new variable to explicitly track failures fixes the problem. Original commit: https://crrev.com/5f8b274cdab547c8afff5429110a97d15353c19c BUG=639690 Committed: https://chromium.googlesource.com/chromium/src/+/9e81a357b3656f2eed03c9bbfda106eb892d9ae8

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -2 lines)			Patch
M	media/blink/multibuffer_data_source.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	media/blink/multibuffer_data_source.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	media/blink/multibuffer_data_source_unittest.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

hubbe

4 years, 3 months ago (2016-08-26 21:47:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9e81a357b3656f2eed03c9bbfda106eb892d9ae8.