Source/web/win/WebInputEventFactory.cpp - Issue 22831043: KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/win/WebInputEventFactory.cpp

Issue 22831043: KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/win/WebInputEventFactory.cpp

diff --git a/Source/web/win/WebInputEventFactory.cpp b/Source/web/win/WebInputEventFactory.cpp

index 4ce69f0ef9828e46b6bf2bc5ff49c26c1beada2e..11f83429258bfdaa9914fa07cc921d1175bb1453 100644

--- a/Source/web/win/WebInputEventFactory.cpp

+++ b/Source/web/win/WebInputEventFactory.cpp

@@ -68,7 +68,6 @@ static int getLocationModifier(WPARAM wparam, LPARAM lparam)

if (!((lparam >> 16) & KF_EXTENDED))

modifier = WebInputEvent::IsKeyPad;

break;

- case VK_NUMLOCK:

case VK_NUMPAD0:

case VK_NUMPAD1:

case VK_NUMPAD2: