Source/testing/runner/EventSender.cpp - Issue 22831043: KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/testing/runner/EventSender.cpp

Issue 22831043: KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/testing/runner/EventSender.cpp

diff --git a/Source/testing/runner/EventSender.cpp b/Source/testing/runner/EventSender.cpp

index 2b1754b1f8a8faf77ba49c24fc2a1a96303c46fc..c460c769e713639d259c2b2760a2c34fbd2cb84e 100644

--- a/Source/testing/runner/EventSender.cpp

+++ b/Source/testing/runner/EventSender.cpp

@@ -602,6 +602,8 @@ void EventSender::keyDown(const CppArgumentList& arguments, CppVariant* result)

code = VKEY_LMENU;

else if ("rightAlt" == codeStr)

code = VKEY_RMENU;

+ else if ("numLock" == codeStr)

+ code = VKEY_NUMLOCK;

else {

// Compare the input string with the function-key names defined by the

// DOM spec (i.e. "F1",...,"F24"). If the input string is a function-key