KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key

KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key

KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key.
This behavior is consistent with IE and Firefox. However, Blink returns
DOM_KEY_LOCATION_NUMPAD for it on Windows (the value is correct on Mac and
Linux).

This patch fixes Blink on Windows to be inline with the others.

BUG=263724
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156693

[arv (Not doing code reviews), 2013-08-23 20:36:16]

LGTM

[tkent, 2013-08-25 22:29:33]

lgtm

https://codereview.chromium.org/22831043/diff/1/LayoutTests/fast/events/keydo...
File LayoutTests/fast/events/keydown-numlock-standard-location.html (right):

https://codereview.chromium.org/22831043/diff/1/LayoutTests/fast/events/keydo...
LayoutTests/fast/events/keydown-numlock-standard-location.html:40: debug("This
test requires DumpRenderTree.");
nit: No DRT any more.

[commit-bot: I haz the power, 2013-08-26 05:51:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22831043/10001

[commit-bot: I haz the power, 2013-08-26 06:59:43]

Change committed as 156693

[Wez, 2013-08-27 01:41:45]

+garykac@, who should probably have been reviewer for this CL. :)

As per the DOM Level 3 Events specification, keys on the numeric pad should be
reported with location DOM_KEY_LOCATION_NUMPAD - since NumLock is on the numeric
keypad, it should also use that value.

[garykac, 2013-08-27 02:15:02]

On 2013/08/27 01:41:45, Wez wrote:
> +garykac@, who should probably have been reviewer for this CL. :)
> 
> As per the DOM Level 3 Events specification, keys on the numeric pad should be
> reported with location DOM_KEY_LOCATION_NUMPAD - since NumLock is on the
numeric
> keypad, it should also use that value.

My interpretation of DOM_KEY_LOCATION_STANDARD is that it is supposed to be used
whenever the key occurs only once on the keyboard.

The non-STANDARD locations: _LEFT, _RIGHT, _NUMPAD are only used when the key
occurs multiple times on the keyboard.

However, with the way the spec is written, it sounds like NumLock should have a
location of DOM_KEY_LOCATION_NUMPAD:
   "The key activation originated on the numeric keypad or with a virtual key
corresponding to the numeric keypad".

Since this can go either way *and* all the other browsers already implement this
as location = STANDARD, I'll update the spec to be clear about the location of
the NumLock key (and I'll confirm the intent with the other editors/www-dom
people).

[masayuki_d-toybox.com, 2013-08-27 13:20:24]

I guess the reason is, NumLock key may not be a part of Numpad. E.g., on 
notebook's keyboard, the key location depends on its OEM vendor.

On 2013/08/27 11:15, garykac@chromium.org wrote:
> On 2013/08/27 01:41:45, Wez wrote:
>> +garykac@, who should probably have been reviewer for this CL. :)
>
>> As per the DOM Level 3 Events specification, keys on the numeric pad
>> should be
>> reported with location DOM_KEY_LOCATION_NUMPAD - since NumLock is on the
> numeric
>> keypad, it should also use that value.
>
> My interpretation of DOM_KEY_LOCATION_STANDARD is that it is supposed to
> be used
> whenever the key occurs only once on the keyboard.
>
> The non-STANDARD locations: _LEFT, _RIGHT, _NUMPAD are only used when
> the key
> occurs multiple times on the keyboard.
>
> However, with the way the spec is written, it sounds like NumLock should
> have a
> location of DOM_KEY_LOCATION_NUMPAD:
>     "The key activation originated on the numeric keypad or with a
> virtual key
> corresponding to the numeric keypad".
>
> Since this can go either way *and* all the other browsers already
> implement this
> as location = STANDARD, I'll update the spec to be clear about the
> location of
> the NumLock key (and I'll confirm the intent with the other editors/www-dom
> people).
>
>
> https://chromiumcodereview.appspot.com/22831043/


-- 
Masayuki Nakano <masayuki@d-toybox.com>
Manager, Internationalization, Mozilla Japan.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Wez, 2013-08-27 20:55:43]

OK, SGTM


On 27 August 2013 06:20, Masayuki Nakano <masayuki@d-toybox.com> wrote:

> I guess the reason is, NumLock key may not be a part of Numpad. E.g., on
> notebook's keyboard, the key location depends on its OEM vendor.
>
>
> On 2013/08/27 11:15, garykac@chromium.org wrote:
>
>> On 2013/08/27 01:41:45, Wez wrote:
>>
>>> +garykac@, who should probably have been reviewer for this CL. :)
>>>
>>
>>  As per the DOM Level 3 Events specification, keys on the numeric pad
>>> should be
>>> reported with location DOM_KEY_LOCATION_NUMPAD - since NumLock is on the
>>>
>> numeric
>>
>>> keypad, it should also use that value.
>>>
>>
>> My interpretation of DOM_KEY_LOCATION_STANDARD is that it is supposed to
>> be used
>> whenever the key occurs only once on the keyboard.
>>
>> The non-STANDARD locations: _LEFT, _RIGHT, _NUMPAD are only used when
>> the key
>> occurs multiple times on the keyboard.
>>
>> However, with the way the spec is written, it sounds like NumLock should
>> have a
>> location of DOM_KEY_LOCATION_NUMPAD:
>>     "The key activation originated on the numeric keypad or with a
>> virtual key
>> corresponding to the numeric keypad".
>>
>> Since this can go either way *and* all the other browsers already
>> implement this
>> as location = STANDARD, I'll update the spec to be clear about the
>> location of
>> the NumLock key (and I'll confirm the intent with the other
>> editors/www-dom
>> people).
>>
>>
>>
https://chromiumcodereview.**appspot.com/22831043/<https://chromiumcodereview...
>>
>
>
> --
> Masayuki Nakano <masayuki@d-toybox.com>
> Manager, Internationalization, Mozilla Japan.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.