Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: cc/resources/managed_tile_state.cc

Issue 22831041: cc: Removed low priority bin from tile management. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/managed_tile_state.h ('k') | cc/resources/prioritized_tile_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/managed_tile_state.cc
diff --git a/cc/resources/managed_tile_state.cc b/cc/resources/managed_tile_state.cc
index cf4a7a7b869520b40757bca3873eb16c2702c75e..4583e5329068e45c647dd5ce343f465c05aff726 100644
--- a/cc/resources/managed_tile_state.cc
+++ b/cc/resources/managed_tile_state.cc
@@ -12,52 +12,42 @@ namespace cc {
scoped_ptr<base::Value> ManagedTileBinAsValue(ManagedTileBin bin) {
switch (bin) {
- case NOW_AND_READY_TO_DRAW_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "NOW_AND_READY_TO_DRAW_BIN"));
- case NOW_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "NOW_BIN"));
- case SOON_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "SOON_BIN"));
- case EVENTUALLY_AND_ACTIVE_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "EVENTUALLY_AND_ACTIVE_BIN"));
- case EVENTUALLY_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "EVENTUALLY_BIN"));
- case NEVER_AND_ACTIVE_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "NEVER_AND_ACTIVE_BIN"));
- case NEVER_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "NEVER_BIN"));
- default:
- DCHECK(false) << "Unrecognized ManagedTileBin value " << bin;
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "<unknown ManagedTileBin value>"));
- }
-}
-
-scoped_ptr<base::Value> ManagedTileBinPriorityAsValue(
- ManagedTileBinPriority bin_priority) {
- switch (bin_priority) {
- case HIGH_PRIORITY_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "HIGH_PRIORITY_BIN"));
- case LOW_PRIORITY_BIN:
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "LOW_PRIORITY_BIN"));
- default:
- DCHECK(false) << "Unrecognized ManagedTileBinPriority value";
- return scoped_ptr<base::Value>(base::Value::CreateStringValue(
- "<unknown ManagedTileBinPriority value>"));
+ case NOW_AND_READY_TO_DRAW_BIN:
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("NOW_AND_READY_TO_DRAW_BIN"));
+ case NOW_BIN:
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("NOW_BIN"));
+ case SOON_BIN:
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("SOON_BIN"));
+ case EVENTUALLY_AND_ACTIVE_BIN:
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("EVENTUALLY_AND_ACTIVE_BIN"));
+ case EVENTUALLY_BIN:
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("EVENTUALLY_BIN"));
+ case AT_LAST_AND_ACTIVE_BIN:
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("AT_LAST_AND_ACTIVE_BIN"));
+ case AT_LAST_BIN:
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("AT_LAST_BIN"));
+ case NEVER_BIN:
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("NEVER_BIN"));
+ case NUM_BINS:
+ NOTREACHED();
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("Invalid Bin (NUM_BINS)"));
}
+ return scoped_ptr<base::Value>(
+ base::Value::CreateStringValue("Invalid Bin (UNKNOWN)"));
}
ManagedTileState::ManagedTileState()
: raster_mode(LOW_QUALITY_RASTER_MODE),
+ bin(NEVER_BIN),
gpu_memmgr_stats_bin(NEVER_BIN),
resolution(NON_IDEAL_RESOLUTION),
required_for_activation(false),
@@ -65,10 +55,8 @@ ManagedTileState::ManagedTileState()
distance_to_visible_in_pixels(std::numeric_limits<float>::infinity()),
visible_and_ready_to_draw(false),
scheduled_priority(0) {
- for (int i = 0; i < NUM_TREES; ++i) {
+ for (int i = 0; i < NUM_TREES; ++i)
tree_bin[i] = NEVER_BIN;
- bin[i] = NEVER_BIN;
- }
}
ManagedTileState::TileVersion::TileVersion()
@@ -105,10 +93,12 @@ scoped_ptr<base::Value> ManagedTileState::AsValue() const {
scoped_ptr<base::DictionaryValue> state(new base::DictionaryValue());
state->SetBoolean("has_resource",
tile_versions[raster_mode].resource_.get() != 0);
- state->Set("bin.0", ManagedTileBinAsValue(bin[ACTIVE_TREE]).release());
- state->Set("bin.1", ManagedTileBinAsValue(bin[PENDING_TREE]).release());
+ state->Set("tree_bin.0",
+ ManagedTileBinAsValue(tree_bin[ACTIVE_TREE]).release());
+ state->Set("tree_bin.1",
+ ManagedTileBinAsValue(tree_bin[PENDING_TREE]).release());
state->Set("gpu_memmgr_stats_bin",
- ManagedTileBinAsValue(bin[ACTIVE_TREE]).release());
+ ManagedTileBinAsValue(gpu_memmgr_stats_bin).release());
state->Set("resolution", TileResolutionAsValue(resolution).release());
state->Set("time_to_needed_in_seconds",
MathUtil::AsValueSafely(time_to_needed_in_seconds).release());
« no previous file with comments | « cc/resources/managed_tile_state.h ('k') | cc/resources/prioritized_tile_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698