cc: Removed low priority bin from tile management.

cc/resources/prioritized_tile_set.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/prioritized_tile_set.h"
 
 #include <algorithm>
 
 #include "cc/resources/managed_tile_state.h"
 #include "cc/resources/tile.h"
 
 namespace cc {
 
 class BinComparator {
  public:
   bool operator()(const Tile* a,
                   const Tile* b) const {
     const ManagedTileState& ams = a->managed_state();
     const ManagedTileState& bms = b->managed_state();
 
-    if (ams.bin[LOW_PRIORITY_BIN] != bms.bin[LOW_PRIORITY_BIN])
-      return ams.bin[LOW_PRIORITY_BIN] < bms.bin[LOW_PRIORITY_BIN];
-
     if (ams.required_for_activation != bms.required_for_activation)
       return ams.required_for_activation;
 
     if (ams.resolution != bms.resolution)
       return ams.resolution < bms.resolution;
 
     if (ams.time_to_needed_in_seconds !=  bms.time_to_needed_in_seconds)
       return ams.time_to_needed_in_seconds < bms.time_to_needed_in_seconds;
 
     if (ams.distance_to_visible_in_pixels !=
@@ skipping 10 matching lines @@
   }
 };
 
 namespace {
 
 typedef std::vector<Tile*> TileVector;
 
 void SortBinTiles(ManagedTileBin bin, TileVector* tiles) {
   switch (bin) {
     case NOW_AND_READY_TO_DRAW_BIN:
+    case NEVER_BIN:
       break;
     case NOW_BIN:
     case SOON_BIN:
     case EVENTUALLY_AND_ACTIVE_BIN:
     case EVENTUALLY_BIN:
-    case NEVER_AND_ACTIVE_BIN:
-    case NEVER_BIN:
+    case AT_LAST_AND_ACTIVE_BIN:
+    case AT_LAST_BIN:
       std::sort(tiles->begin(), tiles->end(), BinComparator());
       break;
-    default:
+    case NUM_BINS:

[reveman, 2013/08/26 23:22:13]

nit: "default: NOTREACHED()" would be more consistent at the moment.

[danakj, 2013/08/27 02:23:43]

:(

       NOTREACHED();
   }
 }
 
 }  // namespace
 
 PrioritizedTileSet::PrioritizedTileSet() {
   for (int bin = 0; bin < NUM_BINS; ++bin)
     bin_sorted_[bin] = true;
 }
@@ skipping 62 matching lines @@
     if (use_priority_ordering_)
       tile_set_->SortBinIfNeeded(current_bin_);
 
     iterator_ = tile_set_->tiles_[current_bin_].begin();
     if (iterator_ != tile_set_->tiles_[current_bin_].end())
       break;
   }
 }
 
 }  // namespace cc