Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22831038: Issue 12566. Add 'Who declares' and 'Who uses' items into omnibox. (Closed)

Created:
7 years, 4 months ago by scheglov
Modified:
7 years, 4 months ago
Reviewers:
messick
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 12566. Add 'Who declares' and 'Who uses' items into omnibox. https://code.google.com/p/dart/issues/detail?id=12566 R=messick@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26571

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 4 months ago (2013-08-22 21:14:43 UTC) #1
messick
lgtm https://codereview.chromium.org/22831038/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/messages.properties File editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/messages.properties (right): https://codereview.chromium.org/22831038/diff/1/editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/messages.properties#newcode19 editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/messages.properties:19: WhoDeclaresElement_label=Who declares ''{0}'' I'm not convinced that using ...
7 years, 4 months ago (2013-08-22 21:40:22 UTC) #2
scheglov
7 years, 4 months ago (2013-08-22 23:53:47 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r26571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698