Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: blimp/tools/client_engine_integration.py

Issue 2283083002: Detach engine popen process with parent process (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/tools/client_engine_integration.py
diff --git a/blimp/tools/client_engine_integration.py b/blimp/tools/client_engine_integration.py
index 3f45e3fb8a5dae93ffc23f3c3dfd8426b319493d..6918ae289c5528dd7a6f654c49442a213e12c5e8 100755
--- a/blimp/tools/client_engine_integration.py
+++ b/blimp/tools/client_engine_integration.py
@@ -105,7 +105,8 @@ def RunEngine(output_linux_directory, token_file_path, device):
' --vmodule="blimp*=1"']
p = subprocess.Popen(run_engine_cmd, shell=True,
stdout=subprocess.PIPE,
- stderr=subprocess.STDOUT)
+ stderr=subprocess.STDOUT,
+ preexec_fn=os.setsid)
shenghuazhang 2016/08/26 19:47:41 This shall creates a new process for the popen. No
jbudorick 2016/08/26 21:15:06 No, the simulation test won't verify this. Testing
for line in iter(p.stdout.readline, ''):
sys.stdout.write(line)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698