Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2283083002:
Detach engine popen process with parent process (Closed)
|
Created:
4 years, 3 months ago by shenghuazhang Modified:
4 years, 3 months ago Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDetach engine popen process with parent process
Linked with CL: https://codereview.chromium.org/2269303002/
BUG=640368
Committed: https://crrev.com/9a2dad0aa44d3bb2940d7a4da276dcbfc8a98859
Cr-Commit-Position: refs/heads/master@{#415221}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (8 generated)
Description was changed from ========== Detach engine popen process with parent process BUG=640368 ========== to ========== Detach engine popen process with parent process Linked with CL: https://codereview.chromium.org/2269303002/ BUG=640368 ==========
shenghuazhang@chromium.org changed reviewers: + jbudorick@chromium.org
https://codereview.chromium.org/2283083002/diff/1/blimp/tools/client_engine_i... File blimp/tools/client_engine_integration.py (right): https://codereview.chromium.org/2283083002/diff/1/blimp/tools/client_engine_i... blimp/tools/client_engine_integration.py:109: preexec_fn=os.setsid) This shall creates a new process for the popen. Not sure if this could avoid recipe waiting though. Couldn't I check it unless commit it into the bot? 'scripts/slave/unittests/recipe_simulation_test.py train' won't verify this I think.
lgtm https://codereview.chromium.org/2283083002/diff/1/blimp/tools/client_engine_i... File blimp/tools/client_engine_integration.py (right): https://codereview.chromium.org/2283083002/diff/1/blimp/tools/client_engine_i... blimp/tools/client_engine_integration.py:109: preexec_fn=os.setsid) On 2016/08/26 19:47:41, shenghuazhang1 wrote: > This shall creates a new process for the popen. Not sure if this could avoid > recipe waiting though. > Couldn't I check it unless commit it into the bot? > 'scripts/slave/unittests/recipe_simulation_test.py train' won't verify this I > think. No, the simulation test won't verify this. Testing it on an fyi bot is probably the best way to see if it works.
The CQ bit was checked by shenghuazhang@chromium.org
The CQ bit was unchecked by shenghuazhang@chromium.org
shenghuazhang@chromium.org changed reviewers: + nyquist@chromium.org
@nyquist Could you please review on this as project owner?
lgtm
The CQ bit was checked by shenghuazhang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Detach engine popen process with parent process Linked with CL: https://codereview.chromium.org/2269303002/ BUG=640368 ========== to ========== Detach engine popen process with parent process Linked with CL: https://codereview.chromium.org/2269303002/ BUG=640368 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Detach engine popen process with parent process Linked with CL: https://codereview.chromium.org/2269303002/ BUG=640368 ========== to ========== Detach engine popen process with parent process Linked with CL: https://codereview.chromium.org/2269303002/ BUG=640368 Committed: https://crrev.com/9a2dad0aa44d3bb2940d7a4da276dcbfc8a98859 Cr-Commit-Position: refs/heads/master@{#415221} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9a2dad0aa44d3bb2940d7a4da276dcbfc8a98859 Cr-Commit-Position: refs/heads/master@{#415221} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
