Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2283073002: Cleanup startup_metric_utils.h/.cc. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
gab
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup startup_metric_utils.h/.cc. - Remove unused function GetStartupTemperature() - Move GetHardFaultCountForCurrentProcess() to the anonymous namespace. This cleanup is a first step toward refactoring startup_metric_utils. BUG=580207 Committed: https://crrev.com/e848786d67900e32fd82d03ed30d8330af529cdb Cr-Commit-Position: refs/heads/master@{#415731}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -101 lines) Patch
M components/startup_metric_utils/browser/startup_metric_utils.h View 3 chunks +0 lines, -34 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.cc View 8 chunks +80 lines, -67 lines 2 comments Download

Messages

Total messages: 13 (7 generated)
fdoray
PTAL
4 years, 3 months ago (2016-08-26 19:23:55 UTC) #3
gab
lgtm https://codereview.chromium.org/2283073002/diff/1/components/startup_metric_utils/browser/startup_metric_utils.cc File components/startup_metric_utils/browser/startup_metric_utils.cc (right): https://codereview.chromium.org/2283073002/diff/1/components/startup_metric_utils/browser/startup_metric_utils.cc#newcode131 components/startup_metric_utils/browser/startup_metric_utils.cc:131: bool GetHardFaultCountForCurrentProcess(uint32_t* hard_fault_count) { Assuming cut&paste as-is, not ...
4 years, 3 months ago (2016-08-31 16:30:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283073002/1
4 years, 3 months ago (2016-08-31 19:07:24 UTC) #9
fdoray
https://codereview.chromium.org/2283073002/diff/1/components/startup_metric_utils/browser/startup_metric_utils.cc File components/startup_metric_utils/browser/startup_metric_utils.cc (right): https://codereview.chromium.org/2283073002/diff/1/components/startup_metric_utils/browser/startup_metric_utils.cc#newcode131 components/startup_metric_utils/browser/startup_metric_utils.cc:131: bool GetHardFaultCountForCurrentProcess(uint32_t* hard_fault_count) { On 2016/08/31 16:30:45, gab wrote: ...
4 years, 3 months ago (2016-08-31 19:08:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:04:19 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:05:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e848786d67900e32fd82d03ed30d8330af529cdb
Cr-Commit-Position: refs/heads/master@{#415731}

Powered by Google App Engine
This is Rietveld 408576698