Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2282963002: Do not use NullVideoSink::new_frame_cb_ if NULL. (Closed)

Created:
4 years, 3 months ago by alokp
Modified:
4 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use NullVideoSink::new_frame_cb_ if NULL. Committed: https://crrev.com/419ef372957eebb8983f9385f104569af49d9463 Cr-Commit-Position: refs/heads/master@{#414852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/base/null_video_sink.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
alokp
4 years, 3 months ago (2016-08-26 17:35:00 UTC) #2
xhwang
lgtm
4 years, 3 months ago (2016-08-26 19:05:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282963002/1
4 years, 3 months ago (2016-08-26 19:07:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 23:01:28 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 23:03:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/419ef372957eebb8983f9385f104569af49d9463
Cr-Commit-Position: refs/heads/master@{#414852}

Powered by Google App Engine
This is Rietveld 408576698