Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2282953003: Update the cached WindowAndroid in PermissionInfobar after reparenting (Closed)

Created:
4 years, 3 months ago by Ian Wen
Modified:
4 years, 3 months ago
Reviewers:
Ted C, gone
CC:
chromium-reviews, dfalcantara+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the cached WindowAndroid in PermissionInfobar after reparenting WindowAndroid object is cached in PermissionInfobars, and the object is not updated since their creation. Yet after reparenting, WindowAndroid has changed. This CL fixes this issue by adding a new public call, onTabReparented() to Infobar.java BUG=632477 Committed: https://crrev.com/6407ce083e5bba8e55118236b74fca4a76a13c8c Cr-Commit-Position: refs/heads/master@{#414849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
PTAL
4 years, 3 months ago (2016-08-26 21:45:22 UTC) #2
gone
lgtm
4 years, 3 months ago (2016-08-26 21:55:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282953003/1
4 years, 3 months ago (2016-08-26 22:13:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 22:58:46 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 23:01:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6407ce083e5bba8e55118236b74fca4a76a13c8c
Cr-Commit-Position: refs/heads/master@{#414849}

Powered by Google App Engine
This is Rietveld 408576698