Fix mojo dependencies for component build.

Fix mojo dependencies for component build.

mojo_environment_chromium is a static_library which depends
on mojo_environment_chromium_impl (a .so in component=shared_lib).
mojo_environment_chromium_impl in turn depends on mojo_common_lib
(another .so in component build).
However, at the same time, mojo_environment_chromium:environment.cc
funcionally depends on mojo_common_lib:environment_data.cc, but there
is no direct dependency from mojo_environment_chromium to
mojo_common_lib. Relying on the transitive dependency (via
mojo_environment_chromium_impl) is fine for static_library build,
but not for component=shared_library build.
This CL simply adds the aforementioned missing direct dependency.

BUG=159847
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262445

[Primiano Tucci (use gerrit), 2014-04-08 11:28:17]

Could you PTAL.
Essentially I am trying to make Android targets --gc-sections free. The final
plan is remove the --gc-sections from Android when building in Debug. We
shouldn't funcionally relying on --gc-sections that to build.

The actual problem which triggered this CL is the following:
When building Android targets without --gc-sections, I get the following error
(which disappears applying this CL)

[5567/13577] SOLINK lib/libmojo_gles2_impl.cr.so
FAILED: if [ ! -e lib/libmojo_gles2_impl.cr.so -o ! -e
lib/libmojo_gles2_impl.cr.so.TOC ]; then /usr/local/google/goma/gomacc
/src/chrome/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-shared -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -Wl,-z,noexecstack -fPIC
-fuse-ld=gold -nostdlib -Wl,--no-undefined
--sysroot=/src/chrome/src/third_party/android_tools/ndk//platforms/android-14/arch-arm
-Wl,--icf=safe
-L/src/chrome/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/libs/armeabi-v7a
-Wl,-shared,-Bsymbolic
/src/chrome/src/third_party/android_tools/ndk//platforms/android-14/arch-arm/usr/lib/crtbegin_so.o
-Wl,--warn-shared-textrel -Wl,-O1 -Wl,--as-needed -o
lib/libmojo_gles2_impl.cr.so -Wl,-soname=libmojo_gles2_impl.cr.so
@lib/libmojo_gles2_impl.cr.so.rsp && { readelf -d lib/libmojo_gles2_impl.cr.so |
grep SONAME ; nm -gD -f p lib/libmojo_gles2_impl.cr.so | cut -f1-2 -d' '; } >
lib/libmojo_gles2_impl.cr.so.TOC; else /usr/local/google/goma/gomacc
/src/chrome/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-shared -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -Wl,-z,noexecstack -fPIC
-fuse-ld=gold -nostdlib -Wl,--no-undefined
--sysroot=/src/chrome/src/third_party/android_tools/ndk//platforms/android-14/arch-arm
-Wl,--icf=safe
-L/src/chrome/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/libs/armeabi-v7a
-Wl,-shared,-Bsymbolic
/src/chrome/src/third_party/android_tools/ndk//platforms/android-14/arch-arm/usr/lib/crtbegin_so.o
-Wl,--warn-shared-textrel -Wl,-O1 -Wl,--as-needed -o
lib/libmojo_gles2_impl.cr.so -Wl,-soname=libmojo_gles2_impl.cr.so
@lib/libmojo_gles2_impl.cr.so.rsp && { readelf -d lib/libmojo_gles2_impl.cr.so |
grep SONAME ; nm -gD -f p lib/libmojo_gles2_impl.cr.so | cut -f1-2 -d' '; } >
lib/libmojo_gles2_impl.cr.so.tmp && if ! cmp -s lib/libmojo_gles2_impl.cr.so.tmp
lib/libmojo_gles2_impl.cr.so.TOC; then mv lib/libmojo_gles2_impl.cr.so.tmp
lib/libmojo_gles2_impl.cr.so.TOC ; fi; fi
/src/chrome/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld.gold:
obj/mojo/libmojo_environment_chromium.a(obj/mojo/environment/mojo_environment_chromium.environment.o):
in function
mojo::Environment::Data::Data():../../mojo/environment/environment.cc:22: error:
undefined reference to 'mojo::common::EnvironmentData::EnvironmentData()'
/src/chrome/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld.gold:
obj/mojo/libmojo_environment_chromium.a(obj/mojo/environment/mojo_environment_chromium.environment.o):
in function
mojo::Environment::Data::~Data():../../mojo/environment/environment.cc:26:
error: undefined reference to
'mojo::common::EnvironmentData::~EnvironmentData()'
/src/chrome/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld.gold:
obj/mojo/libmojo_environment_chromium.a(obj/mojo/environment/mojo_environment_chromium.environment.o):
in function
mojo::Environment::Environment():../../mojo/environment/environment.cc:22:
error: undefined reference to 'mojo::common::EnvironmentData::EnvironmentData()'
/src/chrome/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld.gold:
obj/mojo/libmojo_environment_chromium.a(obj/mojo/environment/mojo_environment_chromium.environment.o):
in function
mojo::Environment::~Environment():../../mojo/environment/environment.cc:26:
error: undefined reference to
'mojo::common::EnvironmentData::~EnvironmentData()'

[viettrungluu, 2014-04-08 16:22:59]

Thanks, LGTM.

[Primiano Tucci (use gerrit), 2014-04-08 16:31:36]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2014-04-08 16:31:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/primiano@chromium.org/228293005/1

[commit-bot: I haz the power, 2014-04-08 17:35:59]

Change committed as 262445