chrome/browser/ui/views/frame/browser_view.cc - Issue 228293004: InfoBarService inherits from InfoBarManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 228293004: InfoBarService inherits from InfoBarManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 932d6e29f20f0882435fd71ec15b4588c3269a44..c8c819b38744941c6a9c795b9a153b906af4d270 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -832,9 +832,8 @@ void BrowserView::OnActiveTabChanged(content::WebContents* old_contents,

devtools_web_view_->SetWebContents(NULL);

}

- InfoBarManager* infobar_manager =

- InfoBarService::InfoBarManagerFromWebContents(new_contents);

- infobar_container_->ChangeInfoBarManager(infobar_manager);

+ infobar_container_->ChangeInfoBarManager(

+ InfoBarService::FromWebContents(new_contents));

if (old_contents && PermissionBubbleManager::FromWebContents(old_contents))

PermissionBubbleManager::FromWebContents(old_contents)->SetView(NULL);