Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2097)

Unified Diff: chrome/browser/translate/translate_browsertest.cc

Issue 228293004: InfoBarService inherits from InfoBarManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/translate/translate_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_browsertest.cc
diff --git a/chrome/browser/translate/translate_browsertest.cc b/chrome/browser/translate/translate_browsertest.cc
index e666aeda2912a33d4bddb013dd60b25f175c6e5f..7c0bef781a9f15b32f0f67ccbd758c04a9540258 100644
--- a/chrome/browser/translate/translate_browsertest.cc
+++ b/chrome/browser/translate/translate_browsertest.cc
@@ -92,19 +92,19 @@ class TranslateBrowserTest : public InProcessBrowserTest {
}
TranslateInfoBarDelegate* delegate = NULL;
- InfoBarManager* infobar_manager = infobar_service_->infobar_manager();
- for (size_t i = 0; i < infobar_manager->infobar_count(); ++i) {
+ for (size_t i = 0; i < infobar_service_->infobar_count(); ++i) {
// Check if the shown infobar is a confirm infobar coming from the
// |kTranslateSecurityOrigin| flag specified in SetUpCommandLine().
// This infobar appears in all tests of TranslateBrowserTest and can be
// ignored here.
- ConfirmInfoBarDelegate* confirm = infobar_manager->infobar_at(i)
- ->delegate()->AsConfirmInfoBarDelegate();
- if (confirm)
+ if (infobar_service_->infobar_at(i)->delegate()->
+ AsConfirmInfoBarDelegate()) {
continue;
+ }
- TranslateInfoBarDelegate* translate = infobar_manager->infobar_at(i)
- ->delegate()->AsTranslateInfoBarDelegate();
+ TranslateInfoBarDelegate* translate =
+ infobar_service_->infobar_at(i)->delegate()->
+ AsTranslateInfoBarDelegate();
if (translate) {
EXPECT_FALSE(delegate) << "multiple infobars are shown unexpectedly";
delegate = translate;
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/translate/translate_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698