chrome/browser/extensions/api/debugger/debugger_api.cc - Issue 228293004: InfoBarService inherits from InfoBarManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 228293004: InfoBarService inherits from InfoBarManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/debugger/debugger_api.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc

index b0afffb3ef3d8764d5ab8c97d624c0f4cf86684c..839f9990c8b1f347d481ba6835142bc114c93ffc 100644

--- a/chrome/browser/extensions/api/debugger/debugger_api.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc

@@ -25,7 +25,6 @@

#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/infobars/confirm_infobar_delegate.h"

#include "chrome/browser/infobars/infobar.h"

-#include "chrome/browser/infobars/infobar_manager.h"

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"

@@ -342,7 +341,7 @@ ExtensionDevToolsClientHost::~ExtensionDevToolsClientHost() {

infobar_->delegate())->set_client_host(NULL);

InfoBarService* infobar_service = InfoBarService::FromWebContents(

WebContents::FromRenderViewHost(agent_host_->GetRenderViewHost()));

- infobar_service->infobar_manager()->RemoveInfoBar(infobar_);

+ infobar_service->RemoveInfoBar(infobar_);

}

AttachedClientHosts::GetInstance()->Remove(this);

}