chrome/browser/android/tab_android.cc - Issue 228293004: InfoBarService inherits from InfoBarManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.cc

Issue 228293004: InfoBarService inherits from InfoBarManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.cc

diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc

index fdd4766ada31718c6318283de6213422c33a0829..e7971012876c8449ea123caab099edbc97319adc 100644

--- a/chrome/browser/android/tab_android.cc

+++ b/chrome/browser/android/tab_android.cc

@@ -231,9 +231,9 @@ void TabAndroid::SwapTabContents(content::WebContents* old_contents,

Java_Tab_getNativeInfoBarContainer(

env,

weak_java_tab_.get(env).obj()));

- InfoBarManager* new_infobar_manager = new_contents ?

- InfoBarService::InfoBarManagerFromWebContents(new_contents) : NULL;

- infobar_container->ChangeInfoBarManager(new_infobar_manager);

+ InfoBarService* new_infobar_service =

+ new_contents ? InfoBarService::FromWebContents(new_contents) : NULL;

+ infobar_container->ChangeInfoBarManager(new_infobar_service);

Java_Tab_swapWebContents(

env,