Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3003)

Unified Diff: chrome/browser/translate/translate_browsertest.cc

Issue 228293004: InfoBarService inherits from InfoBarManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: whitespace Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_browsertest.cc
diff --git a/chrome/browser/translate/translate_browsertest.cc b/chrome/browser/translate/translate_browsertest.cc
index e7e26c1b14d168dbaf34e140419a16a4062d75c6..6686eed468a373f9e794f18fae99de1b311b844e 100644
--- a/chrome/browser/translate/translate_browsertest.cc
+++ b/chrome/browser/translate/translate_browsertest.cc
@@ -92,19 +92,20 @@ class TranslateBrowserTest : public InProcessBrowserTest {
}
TranslateInfoBarDelegate* delegate = NULL;
- InfoBarManager* infobar_manager = infobar_service_->infobar_manager();
- for (size_t i = 0; i < infobar_manager->infobar_count(); ++i) {
+ for (size_t i = 0; i < infobar_service_->infobar_count(); ++i) {
// Check if the shown infobar is a confirm infobar coming from the
// |kTranslateSecurityOrigin| flag specified in SetUpCommandLine().
// This infobar appears in all tests of TranslateBrowserTest and can be
// ignored here.
- ConfirmInfoBarDelegate* confirm = infobar_manager->infobar_at(i)
- ->delegate()->AsConfirmInfoBarDelegate();
+ ConfirmInfoBarDelegate* confirm = infobar_service_->infobar_at(i)
+ ->delegate()
+ ->AsConfirmInfoBarDelegate();
Peter Kasting 2014/04/10 00:08:59 Nit: I'd condense/wrap like this: if (infob
if (confirm)
continue;
- TranslateInfoBarDelegate* translate = infobar_manager->infobar_at(i)
- ->delegate()->AsTranslateInfoBarDelegate();
+ TranslateInfoBarDelegate* translate = infobar_service_->infobar_at(i)
+ ->delegate()
+ ->AsTranslateInfoBarDelegate();
if (translate) {
EXPECT_FALSE(delegate) << "multiple infobars are shown unexpectedly";
delegate = translate;

Powered by Google App Engine
This is Rietveld 408576698