chrome/browser/extensions/webstore_startup_installer_browsertest.cc - Issue 228293004: InfoBarService inherits from InfoBarManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_startup_installer_browsertest.cc

Issue 228293004: InfoBarService inherits from InfoBarManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: whitespace Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_interactive_uitest.cc ('K') | « chrome/browser/extensions/theme_installed_infobar_delegate.cc ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc » ('j') | chrome/browser/infobars/infobar_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_startup_installer_browsertest.cc

diff --git a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc

index 4f11ef967f6af6b48c90140f952bbc81d070e69b..cb931787a6c3ef078e9e4360f2afcca23922a1a1 100644

--- a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc

+++ b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc

@@ -8,7 +8,6 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/startup_helper.h"

#include "chrome/browser/extensions/webstore_installer_test.h"

-#include "chrome/browser/infobars/infobar_manager.h"

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/managed_mode/managed_user_service.h"

#include "chrome/browser/managed_mode/managed_user_service_factory.h"

@@ -201,9 +200,8 @@ IN_PROC_BROWSER_TEST_F(WebstoreStartupInstallerManagedUsersTest,

// No error infobar should show up.

WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();

- InfoBarManager* infobar_manager =

- InfoBarService::FromWebContents(contents)->infobar_manager();

- EXPECT_EQ(infobar_manager->infobar_count(), 0u);

+ InfoBarService* infobar_service = InfoBarService::FromWebContents(contents);

+ EXPECT_EQ(infobar_service->infobar_count(), 0u);

Peter Kasting 2014/04/10 00:08:59 Nit: While here: (expected, actual)

}

// The unpack failure test needs to use a different install .crx, which is