Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2282903003: Remove MouseWarpController construction from ash::DisplayManager (Closed)

Created:
4 years, 3 months ago by rjkroege
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MouseWarpController construction from ash::DisplayManager MouseWarpController and its implemenations must be implemented differently in mus so separate them from the eventually shared between ash and mus DisplayManager code. BUG=581462 Committed: https://crrev.com/1866047987d8be2c17a19d7c820590a661076db5 Cr-Commit-Position: refs/heads/master@{#415788}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M ash/display/display_manager.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M ash/display/display_manager.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M ash/display/display_util.h View 1 2 chunks +15 lines, -11 lines 0 comments Download
M ash/display/display_util.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rjkroege
ptal.
4 years, 3 months ago (2016-08-26 21:33:07 UTC) #2
oshima
lgtm
4 years, 3 months ago (2016-08-26 22:01:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282903003/20001
4 years, 3 months ago (2016-08-31 21:50:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 22:38:44 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:42:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1866047987d8be2c17a19d7c820590a661076db5
Cr-Commit-Position: refs/heads/master@{#415788}

Powered by Google App Engine
This is Rietveld 408576698