LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt - Issue 22829002: Throw an exception when denying access to 'Frame's 'location' setter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt

Issue 22829002: Throw an exception when denying access to 'Frame's 'location' setter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html ('k') | Source/bindings/v8/BindingSecurity.h » ('j') | Source/bindings/v8/BindingSecurity.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from access ing a frame with origin "http://localhost:8000". Protocols, domains, and ports m ust match.	1 CONSOLE MESSAGE: line 34: Caught exception while setting frame's location to 'ja vascript:"FAIL: this should not have been loaded."'. 'SecurityError: Blocked a f rame with origin "http://127.0.0.1:8000" from accessing a frame with origin "htt p://localhost:8000". Protocols, domains, and ports must match.'.

2 CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from access ing a frame with origin "http://localhost:8000". Protocols, domains, and ports m ust match.	2 CONSOLE MESSAGE: line 34: Caught exception while setting frame's location to ' j avascript:"FAIL: this should not have been loaded."'. 'SecurityError: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "ht tp://localhost:8000". Protocols, domains, and ports must match.'.

3 CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from access ing a frame with origin "http://localhost:8000". Protocols, domains, and ports m ust match.	3 CONSOLE MESSAGE: line 34: Caught exception while setting frame's location to 'ja vascript» :"FAIL: this should not have been loaded."'. 'SecurityError: Blo cked a frame with origin "http://127.0.0.1:8000" from accessing a frame with ori gin "http://localhost:8000". Protocols, domains, and ports must match.'.
	abarth-chromium 2013/08/12 19:59:18 SecurityError: Blocked a frame with origin "http:/ SecurityError: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. Is the string "http://localhost:8000" contained in the exception in a way that's accessible to the caller? Mike West 2013/08/13 08:30:51 It is. That was stupid. :/ I'm unsure which detai Show quoted text On 2013/08/12 19:59:18, abarth wrote: > Is the string "http://localhost:8000" contained in the exception in a way that's > accessible to the caller? It is. That was stupid. :/ I'm unsure which details are safe to hand to JavaScript. In this CL, I'd like to introduce a 'sanitizedCrossDomainAccessErrorMessage' method that reverts back to our old behavior of just saying "Hey, you're denied access.". As I work through other examples of access violation exceptions, we can evaluate which bits of information might be safe to report.
4	4

5	5

6 --------	6 --------

7 Frame: 'main'	7 Frame: 'main'

8 --------	8 --------

9 This test passes as long as the word 'FAIL' and an accompanying message do not a ppear in the frame below.	9 This test passes as long as the word 'FAIL' and an accompanying message do not a ppear in the frame below.

10	10

11 --------	11 --------

12 Frame: 'aFrame'	12 Frame: 'aFrame'

13 --------	13 --------

14 Inner iframe.	14 Inner iframe.

OLD	NEW