Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: Source/bindings/v8/ExceptionState.h

Issue 22829002: Throw an exception when denying access to 'Frame's 'location' setter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Uncaught. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 class ExceptionState { 44 class ExceptionState {
45 WTF_MAKE_NONCOPYABLE(ExceptionState); 45 WTF_MAKE_NONCOPYABLE(ExceptionState);
46 public: 46 public:
47 explicit ExceptionState(v8::Isolate* isolate) 47 explicit ExceptionState(v8::Isolate* isolate)
48 : m_code(0) 48 : m_code(0)
49 , m_isolate(isolate) { } 49 , m_isolate(isolate) { }
50 50
51 virtual void throwDOMException(const ExceptionCode&, const String& message = String()); 51 virtual void throwDOMException(const ExceptionCode&, const String& message = String());
52 virtual void throwTypeError(const String& message = String()); 52 virtual void throwTypeError(const String& message = String());
53 virtual void throwSecurityError(const String& sanitizedMessage, const String & unsanitizedMessage = String());
53 54
54 bool hadException() const { return !m_exception.isEmpty() || m_code; } 55 bool hadException() const { return !m_exception.isEmpty() || m_code; }
55 void clearException(); 56 void clearException();
56 57
57 ExceptionCode code() { return m_code; } 58 ExceptionCode code() { return m_code; }
58 59
59 bool throwIfNeeded() 60 bool throwIfNeeded()
60 { 61 {
61 if (m_exception.isEmpty()) { 62 if (m_exception.isEmpty()) {
62 if (!m_code) 63 if (!m_code)
(...skipping 12 matching lines...) Expand all
75 void setException(v8::Handle<v8::Value>); 76 void setException(v8::Handle<v8::Value>);
76 77
77 ScopedPersistent<v8::Value> m_exception; 78 ScopedPersistent<v8::Value> m_exception;
78 v8::Isolate* m_isolate; 79 v8::Isolate* m_isolate;
79 }; 80 };
80 81
81 class TrackExceptionState : public ExceptionState { 82 class TrackExceptionState : public ExceptionState {
82 public: 83 public:
83 TrackExceptionState(): ExceptionState(0) { } 84 TrackExceptionState(): ExceptionState(0) { }
84 virtual void throwDOMException(const ExceptionCode&, const String& message = String()) OVERRIDE FINAL; 85 virtual void throwDOMException(const ExceptionCode&, const String& message = String()) OVERRIDE FINAL;
85 virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL ; 86 virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL ;
arv (Not doing code reviews) 2013/08/14 13:43:03 Please add it here too... and in ExceptionStatePla
Use mkwst_at_chromium.org plz. 2013/08/14 13:57:21 Very good catch, thank you.
86 }; 87 };
87 88
88 } // namespace WebCore 89 } // namespace WebCore
89 90
90 #endif // ExceptionState_h 91 #endif // ExceptionState_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698