Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2282893002: Remove appurify python client from Chromium DEPS. (Closed)

Created:
4 years, 3 months ago by bpastene
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove appurify python client from Chromium DEPS. BUG= TBR=jbudorick@chromium.org Committed: https://crrev.com/65c6909d97990f33919a4a0b6aa54a5329833742 Cr-Commit-Position: refs/heads/master@{#414873}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix py deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -219 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/android.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_runner.pydeps View 2 chunks +0 lines, -12 lines 0 comments Download
D third_party/appurify-python/LICENSE View 1 chunk +0 lines, -192 lines 0 comments Download
D third_party/appurify-python/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/appurify-python/README.chromium View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
bpastene
Pretty sure we don't need this anymore.
4 years, 3 months ago (2016-08-26 17:12:35 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/2282893002/diff/1/build/android/test_runner.pydeps File build/android/test_runner.pydeps (left): https://codereview.chromium.org/2282893002/diff/1/build/android/test_runner.pydeps#oldcode121 build/android/test_runner.pydeps:121: pylib/remote/device/appurify_constants.py +rnephew I think these can be removed ...
4 years, 3 months ago (2016-08-26 17:28:07 UTC) #4
bpastene
On 2016/08/26 17:28:07, jbudorick wrote: > lgtm > > https://codereview.chromium.org/2282893002/diff/1/build/android/test_runner.pydeps > File build/android/test_runner.pydeps (left): > ...
4 years, 3 months ago (2016-08-26 18:48:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282893002/1
4 years, 3 months ago (2016-08-26 18:49:49 UTC) #7
jbudorick
On 2016/08/26 18:48:08, bpastene wrote: > On 2016/08/26 17:28:07, jbudorick wrote: > > lgtm > ...
4 years, 3 months ago (2016-08-26 18:50:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/247269)
4 years, 3 months ago (2016-08-26 18:57:57 UTC) #10
jbudorick
Not sure why it's complaining about OWNERS for appurify-python... https://codereview.chromium.org/2282893002/diff/1/build/secondary/tools/swarming_client/isolate.pydeps File build/secondary/tools/swarming_client/isolate.pydeps (left): https://codereview.chromium.org/2282893002/diff/1/build/secondary/tools/swarming_client/isolate.pydeps#oldcode9 build/secondary/tools/swarming_client/isolate.pydeps:9: ...
4 years, 3 months ago (2016-08-26 19:01:40 UTC) #11
bpastene
https://codereview.chromium.org/2282893002/diff/1/build/secondary/tools/swarming_client/isolate.pydeps File build/secondary/tools/swarming_client/isolate.pydeps (left): https://codereview.chromium.org/2282893002/diff/1/build/secondary/tools/swarming_client/isolate.pydeps#oldcode9 build/secondary/tools/swarming_client/isolate.pydeps:9: libs/__init__.py On 2016/08/26 19:01:40, jbudorick wrote: > errr these ...
4 years, 3 months ago (2016-08-26 20:06:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282893002/20001
4 years, 3 months ago (2016-08-26 21:44:13 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-27 00:20:02 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 00:22:36 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65c6909d97990f33919a4a0b6aa54a5329833742
Cr-Commit-Position: refs/heads/master@{#414873}

Powered by Google App Engine
This is Rietveld 408576698