Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2282883002: Remove SVG DM serialization suppressions (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2256 lines) Patch
M infra/bots/recipes/swarm_test.py View 1 chunk +0 lines, -10 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-AndroidOne-GPU-Mali400MP2-Arm7-Release.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Debug.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NexusPlayer-CPU-SSE4-x86-Release.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug.json View 1 chunk +1 line, -65 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.json View 1 chunk +1 line, -65 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +1 line, -65 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared.json View 1 chunk +1 line, -65 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +0 lines, -192 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/adb_in_path.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/big_issue_number.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skimage.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skps.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_svgs.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_dm.json View 1 chunk +1 line, -65 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_get_hashes.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SKP_VERSION_device.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SVG_VERSION_device.json View 1 chunk +0 lines, -64 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/recipe_with_gerrit_patch.json View 1 chunk +1 line, -65 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
f(malita)
After https://codereview.chromium.org/2252443002/ we shouldn't be running SVGs on serializing sinks. So I don't think these ...
4 years, 3 months ago (2016-08-26 17:02:55 UTC) #4
mtklein
lgtm
4 years, 3 months ago (2016-08-26 17:04:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282883002/1
4 years, 3 months ago (2016-08-26 17:22:23 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:23:47 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/30afa71dd3812a743cace33aa9e41f7446d6c929

Powered by Google App Engine
This is Rietveld 408576698