Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2282853002: ash: Add comment about where to add new accelerators (Closed)

Created:
4 years, 3 months ago by James Cook
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Add comment about where to add new accelerators It's confusing whether to add new accelerators to AcceleratorController vs. AcceleratorControllerDelegateAura. Add some comments. BUG=none TEST=none Committed: https://crrev.com/d8f7274aa3a3253b72daf9aa111dc7faebeac236 Cr-Commit-Position: refs/heads/master@{#414736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ash/accelerators/accelerator_controller_delegate_aura.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_delegate_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
James Cook
sky, please take a look.
4 years, 3 months ago (2016-08-26 16:02:45 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-08-26 16:41:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282853002/1
4 years, 3 months ago (2016-08-26 17:05:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 17:11:04 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:14:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8f7274aa3a3253b72daf9aa111dc7faebeac236
Cr-Commit-Position: refs/heads/master@{#414736}

Powered by Google App Engine
This is Rietveld 408576698