Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2282833002: Fix |security_bits| comment on SecurityStateModel (Closed)

Created:
4 years, 3 months ago by estark
Modified:
4 years, 3 months ago
Reviewers:
felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix |security_bits| comment on SecurityStateModel BUG=636380 Committed: https://crrev.com/69be1c3956d4dbff1062172e3a9ec19191dbc52f Cr-Commit-Position: refs/heads/master@{#414924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M components/security_state/security_state_model.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
estark
felt, PTAL
4 years, 3 months ago (2016-08-26 15:25:29 UTC) #2
felt
lgtm
4 years, 3 months ago (2016-08-26 19:59:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282833002/1
4 years, 3 months ago (2016-08-27 00:55:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/270113)
4 years, 3 months ago (2016-08-27 02:26:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282833002/1
4 years, 3 months ago (2016-08-27 04:42:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 11:08:59 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 11:11:07 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/69be1c3956d4dbff1062172e3a9ec19191dbc52f
Cr-Commit-Position: refs/heads/master@{#414924}

Powered by Google App Engine
This is Rietveld 408576698