Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2282823002: Remove dependency on Earl Grey from WebViewInteractionTestUtil (Closed)

Created:
4 years, 3 months ago by gambard
Modified:
4 years, 1 month ago
Reviewers:
baxley
CC:
chromium-reviews, jif
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on Earl Grey from WebViewInteractionTestUtil WebViewInteractionTestUtil should not depend on Earl Grey. This CL removes this dependency and also removes the Earl Grey timeout. The current methods using this function should add an assertion on the return value. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M ios/web/public/test/web_view_interaction_test_util.mm View 3 chunks +12 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
gambard
WDYT? I don't think we should be depend on Earl Grey as this already caused ...
4 years, 3 months ago (2016-08-26 14:45:48 UTC) #3
baxley
lgtm
4 years, 3 months ago (2016-08-26 15:02:33 UTC) #4
gambard
I think we should add a Grey Assertion for every use of this function before ...
4 years, 3 months ago (2016-08-26 15:03:17 UTC) #5
baxley
On 2016/08/26 15:03:17, gambard wrote: > I think we should add a Grey Assertion for ...
4 years, 3 months ago (2016-08-26 15:06:39 UTC) #6
gambard
+bzanotti in cc as he was interested in it. PTAL for BUILD.gn changes. I will ...
4 years, 3 months ago (2016-08-26 15:26:39 UTC) #7
gambard
4 years, 3 months ago (2016-08-26 15:32:12 UTC) #8
bzanotti
4 years, 3 months ago (2016-08-26 15:45:44 UTC) #9
On 2016/08/26 15:26:39, gambard (OOO until 12 Sept) wrote:
> +bzanotti in cc as he was interested in it.
> PTAL for BUILD.gn changes.
> I will be OOO for the next two weeks so I cannot do the downstream changes.
The
> changes will need to wait the autoroller for
> https://codereview.chromium.org/2268863004/

Note that this doesn't change a thing for the downstream change. This file is
still compiled alongside ios/web/public/test/earl_grey/web_view_matchers.(h|mm)
in the earl_grey_test_support target.
The file should probably be moved in the test_support target in
ios/web/BUILD.gn.

Powered by Google App Engine
This is Rietveld 408576698