bluetooth: mac: Improve classic device discovery and update

device/bluetooth/bluetooth_device.h

Index: device/bluetooth/bluetooth_device.h
diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
index 2a5389c4f2b363a78ea4a01414b6db50c9748909..66ba89e50582d55e67cbc69d3e2cf64af5ec22b4 100644
--- a/device/bluetooth/bluetooth_device.h
+++ b/device/bluetooth/bluetooth_device.h
@@ -513,8 +513,11 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
   // empty string.
   static std::string CanonicalizeAddress(const std::string& address);
 
+  // Update the last time this device was seen.
+  void UpdateTimestamp();
+
   // Return the timestamp for when this device was last seen.

[Jeffrey Yasskin, 2016/09/23 22:25:21]

Mention what the default return value is.

[ortuno, 2016/09/26 08:45:29]

What do you mean? The default value of base::Time() or the base implementation
value i.e. last_update_time_?

I did the former. Let me know if you meant the other one.

[Jeffrey Yasskin, 2016/09/26 18:35:59]

The base implementation value; probably something like "returns the time of the
last call to UpdateTimestamp(), or base::Time() if it hasn't been called yet."

[ortuno, 2016/09/26 23:58:18]

Done. Thanks for the suggestion :)

-  base::Time GetLastUpdateTime() const { return last_update_time_; }
+  virtual base::Time GetLastUpdateTime() const;
 
   // Called by BluetoothAdapter when a new Advertisement is seen for this
   // device. This replaces previously seen Advertisement Data.
@@ -577,9 +580,6 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
 
   BluetoothDevice(BluetoothAdapter* adapter);
 
-  // Update the last time this device was seen.
-  void UpdateTimestamp();
-
   // Implements platform specific operations to initiate a GATT connection.
   // Subclasses must also call DidConnectGatt, DidFailToConnectGatt, or
   // DidDisconnectGatt immediately or asynchronously as the connection state