bluetooth: mac: Improve classic device discovery and update

device/bluetooth/bluetooth_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 495 matching lines @@
   // Returns the GATT service with device-specific identifier |identifier|.
   // Returns NULL, if no such service exists.
   virtual BluetoothRemoteGattService* GetGattService(
       const std::string& identifier) const;
 
   // Returns the |address| in the canonical format: XX:XX:XX:XX:XX:XX, where
   // each 'X' is a hex digit.  If the input |address| is invalid, returns an
   // empty string.
   static std::string CanonicalizeAddress(const std::string& address);
 
+  // Update the last time this device was seen.
+  void UpdateTimestamp();
+
   // Return the timestamp for when this device was last seen.

[Jeffrey Yasskin, 2016/09/23 22:25:21]

Mention what the default return value is.

[ortuno, 2016/09/26 08:45:29]

What do you mean? The default value of base::Time() or the base implementation
value i.e. last_update_time_?

I did the former. Let me know if you meant the other one.

[Jeffrey Yasskin, 2016/09/26 18:35:59]

The base implementation value; probably something like "returns the time of the
last call to UpdateTimestamp(), or base::Time() if it hasn't been called yet."

[ortuno, 2016/09/26 23:58:18]

Done. Thanks for the suggestion :)

-  base::Time GetLastUpdateTime() const { return last_update_time_; }
+  virtual base::Time GetLastUpdateTime() const;
 
   // Called by BluetoothAdapter when a new Advertisement is seen for this
   // device. This replaces previously seen Advertisement Data.
   void UpdateAdvertisementData(int8_t rssi,
                                UUIDList advertised_uuids,
                                ServiceDataMap service_data,
                                const int8_t* tx_power);
 
   // Called by BluetoothAdapter when it stops discoverying.
   void ClearAdvertisementData();
@@ skipping 42 matching lines @@
    private:
     void UpdateDeviceUUIDs();
 
     BluetoothDevice::UUIDSet advertised_uuids_;
     BluetoothDevice::UUIDSet service_uuids_;
     BluetoothDevice::UUIDSet device_uuids_;
   };
 
   BluetoothDevice(BluetoothAdapter* adapter);
 
-  // Update the last time this device was seen.
-  void UpdateTimestamp();
-
   // Implements platform specific operations to initiate a GATT connection.
   // Subclasses must also call DidConnectGatt, DidFailToConnectGatt, or
   // DidDisconnectGatt immediately or asynchronously as the connection state
   // changes.
   virtual void CreateGattConnectionImpl() = 0;
 
   // Disconnects GATT connection on platforms that maintain a specific GATT
   // connection.
   virtual void DisconnectGatt() = 0;
 
@@ skipping 49 matching lines @@
 
  private:
   // Returns a localized string containing the device's bluetooth address and
   // a device type for display when |name_| is empty.
   base::string16 GetAddressWithLocalizedDeviceTypeName() const;
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_