Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2282753003: Remove entries from CFI blacklist for V8 methods. (Closed)

Created:
4 years, 3 months ago by krasin1
Modified:
4 years, 3 months ago
Reviewers:
kcc2, eugenis
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove entries from CFI blacklist for V8 methods. These methods have been marked with DISABLE_CFI_PERF attribute in https://codereview.chromium.org/2258003002/ and don't need to be double-listed. Also, fix a couple of patterns with double star. BUG=641343, 641536 Committed: https://crrev.com/a4fa82ebaeffef03f51294cad1670aea9a7176c8 Cr-Commit-Position: refs/heads/master@{#414827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M tools/cfi/blacklist.txt View 2 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
krasin1
4 years, 3 months ago (2016-08-26 20:56:52 UTC) #2
eugenis
lgtm
4 years, 3 months ago (2016-08-26 21:07:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282753003/1
4 years, 3 months ago (2016-08-26 21:08:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 22:01:13 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 22:04:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4fa82ebaeffef03f51294cad1670aea9a7176c8
Cr-Commit-Position: refs/heads/master@{#414827}

Powered by Google App Engine
This is Rietveld 408576698