Disable NTP Content Suggestions by default for enterprise users

Disable NTP Content Suggestions by default for enterprise users

BUG=638930
Committed: https://crrev.com/0d54d3681f14bf13b120d1f82835bfedc89804fa
Cr-Commit-Position: refs/heads/master@{#414724}

[Marc Treib, 2016-08-26 11:59:56]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 12:00:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-08-26 12:16:43]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 12:16:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-08-26 12:25:46]

treib@chromium.org changed reviewers:
+ atwilson@chromium.org

[Marc Treib, 2016-08-26 12:25:46]

treib@chromium.org changed reviewers:
+ atwilson@chromium.org

[Marc Treib, 2016-08-26 12:25:46]

Alright, next try! PTAL!

[Marc Treib, 2016-08-26 12:25:46]

Alright, next try! PTAL!

[commit-bot: I haz the power, 2016-08-26 12:55:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 12:55:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2016-08-26 13:12:30]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 13:12:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-08-26 13:13:37]

https://codereview.chromium.org/2282743002/diff/40001/chrome/browser/policy/c...
File chrome/browser/policy/cloud/cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/2282743002/diff/40001/chrome/browser/policy/c...
chrome/browser/policy/cloud/cloud_policy_browsertest.cc:198:
expected->Set(key::kNTPContentSuggestionsEnabled, POLICY_LEVEL_MANDATORY,
From here on, the rest of this function exactly duplicates
GetExpectedDefaultPolicy, so maybe we should just call that instead - WDYT?

[Andrew T Wilson (Slow), 2016-08-26 14:08:05]

LGTM, thanks for diving into this!

https://codereview.chromium.org/2282743002/diff/40001/chrome/browser/policy/c...
File chrome/browser/policy/cloud/cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/2282743002/diff/40001/chrome/browser/policy/c...
chrome/browser/policy/cloud/cloud_policy_browsertest.cc:198:
expected->Set(key::kNTPContentSuggestionsEnabled, POLICY_LEVEL_MANDATORY,
On 2016/08/26 13:13:37, Marc Treib wrote:
> From here on, the rest of this function exactly duplicates
> GetExpectedDefaultPolicy, so maybe we should just call that instead - WDYT?

Yes, please make that change if you don't mind! Or OK to land without it, your
call.

[Marc Treib, 2016-08-26 14:12:11]

https://codereview.chromium.org/2282743002/diff/40001/chrome/browser/policy/c...
File chrome/browser/policy/cloud/cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/2282743002/diff/40001/chrome/browser/policy/c...
chrome/browser/policy/cloud/cloud_policy_browsertest.cc:198:
expected->Set(key::kNTPContentSuggestionsEnabled, POLICY_LEVEL_MANDATORY,
On 2016/08/26 14:08:05, Andrew T Wilson (Slow) wrote:
> On 2016/08/26 13:13:37, Marc Treib wrote:
> > From here on, the rest of this function exactly duplicates
> > GetExpectedDefaultPolicy, so maybe we should just call that instead - WDYT?
> 
> Yes, please make that change if you don't mind! Or OK to land without it, your
> call.

Done.

[Marc Treib, 2016-08-26 14:12:18]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-08-26 14:12:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/2282743002/#ps60001
(title: "GetExpectedTestPolicy calls GetExpectedDefaultPolicy")

[commit-bot: I haz the power, 2016-08-26 14:12:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 16:06:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 16:08:45]

Description was changed from

==========
Disable NTP Content Suggestions by default for enterprise users

BUG=638930
==========

to

==========
Disable NTP Content Suggestions by default for enterprise users

BUG=638930

Committed: https://crrev.com/0d54d3681f14bf13b120d1f82835bfedc89804fa
Cr-Commit-Position: refs/heads/master@{#414724}
==========

[commit-bot: I haz the power, 2016-08-26 16:08:46]

Patchset 4 (id:??) landed as
https://crrev.com/0d54d3681f14bf13b120d1f82835bfedc89804fa
Cr-Commit-Position: refs/heads/master@{#414724}