Update ANGLE to latest as of August 25, 2016

Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
In addition, release builds were crashing in EGLImageTest due to an
apparent disagreement about calling convention on function-pointer to
exported symbol. There is a proper typedef for that in one of their
headers, but I can't seem to include it without creating more problems,
so I just fixed the decoration on our local typedef.

With those changes, all tests pass, and (on my Windows machine), all
GMs and SKPs produce identical results vs. master in angle and angle-gl.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003

Committed: https://skia.googlesource.com/skia/+/e3031b607c7816980d13a3805382afb403fdfa04

[Brian Osman, 2016-08-26 12:59:30]

Description was changed from

==========
Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
Accounting for that, all tests pass - except for EGLImageTest, which
crashes with no callstack, only in release build. Can't land this yet,
obviously.

BUG=skia:
==========

to

==========
Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
Accounting for that, all tests pass - except for EGLImageTest, which
crashes with no callstack, only in release build. Can't land this yet,
obviously.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003
==========

[Brian Osman, 2016-08-26 15:17:12]

Description was changed from

==========
Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
Accounting for that, all tests pass - except for EGLImageTest, which
crashes with no callstack, only in release build. Can't land this yet,
obviously.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003
==========

to

==========
Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
In addition, release builds were crashing in EGLImageTest due to an
apparent disagreement about calling convention on function-pointer to
exported symbol. There is a proper typedef for that in one of their
headers, but I can't seem to include it without creating more problems,
so I just fixed the decoration on our local typedef.

With those changes, all tests pass.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003
==========

[Brian Osman, 2016-08-26 15:32:28]

Description was changed from

==========
Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
In addition, release builds were crashing in EGLImageTest due to an
apparent disagreement about calling convention on function-pointer to
exported symbol. There is a proper typedef for that in one of their
headers, but I can't seem to include it without creating more problems,
so I just fixed the decoration on our local typedef.

With those changes, all tests pass.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003
==========

to

==========
Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
In addition, release builds were crashing in EGLImageTest due to an
apparent disagreement about calling convention on function-pointer to
exported symbol. There is a proper typedef for that in one of their
headers, but I can't seem to include it without creating more problems,
so I just fixed the decoration on our local typedef.

With those changes, all tests pass, and (on my Windows machine), all
GMs and SKPs produce identical results vs. master in angle and angle-gl.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003
==========

[Brian Osman, 2016-08-26 15:34:24]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[Brian Osman, 2016-08-26 15:34:24]

Took a look at latest ANGLE. After a few issues, it's
all working (and it looks like it comes with better F16
support). Not sure if there's any other benefits - haven't
tried to get an ES3 context.

[robertphillips, 2016-08-26 15:43:58]

lgtm

https://codereview.chromium.org/2282733003/diff/20001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/2282733003/diff/20001/gyp/common_variables.gy...
gyp/common_variables.gypi:77: 'skia_egl%': '<(skia_egl)',
over too far ?

https://codereview.chromium.org/2282733003/diff/20001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/2282733003/diff/20001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:1701: }
// ANGLE provides incorrect information ...

?

https://codereview.chromium.org/2282733003/diff/20001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:1726: GR_GL_RGBA;
// same here ?

[Brian Osman, 2016-08-26 15:57:56]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-08-26 15:57:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2282733003/#ps60001
(title: "Fix tab vs spaces")

[commit-bot: I haz the power, 2016-08-26 15:58:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 16:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 16:00:53]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[Brian Osman, 2016-08-26 17:11:43]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 17:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-08-26 17:28:52]

The CQ bit was unchecked by brianosman@google.com

[Brian Osman, 2016-08-26 17:28:56]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-08-26 17:28:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2282733003/#ps80001
(title: "Rebase?")

[commit-bot: I haz the power, 2016-08-26 17:29:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 17:38:00]

Description was changed from

==========
Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
In addition, release builds were crashing in EGLImageTest due to an
apparent disagreement about calling convention on function-pointer to
exported symbol. There is a proper typedef for that in one of their
headers, but I can't seem to include it without creating more problems,
so I just fixed the decoration on our local typedef.

With those changes, all tests pass, and (on my Windows machine), all
GMs and SKPs produce identical results vs. master in angle and angle-gl.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003
==========

to

==========
Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
In addition, release builds were crashing in EGLImageTest due to an
apparent disagreement about calling convention on function-pointer to
exported symbol. There is a proper typedef for that in one of their
headers, but I can't seem to include it without creating more problems,
so I just fixed the decoration on our local typedef.

With those changes, all tests pass, and (on my Windows machine), all
GMs and SKPs produce identical results vs. master in angle and angle-gl.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003

Committed:
https://skia.googlesource.com/skia/+/e3031b607c7816980d13a3805382afb403fdfa04
==========

[commit-bot: I haz the power, 2016-08-26 17:38:01]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/e3031b607c7816980d13a3805382afb403fdfa04