Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2282683002: Use Node stream printer in Node::showNode(). (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Node stream printer in Node::showNode(). This is a preparation to remove WTFLogAlwasy() from Node.cpp. This CL has no behavior changes. BUG=638849 Committed: https://crrev.com/9d0702c27c930fc345318da2db6f33b2769bff5c Cr-Commit-Position: refs/heads/master@{#414726}

Patch Set 1 #

Patch Set 2 : Do not print addresses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -43 lines) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 1 3 chunks +19 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRangeTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-26 09:17:59 UTC) #5
yosin_UTC9
lgtm Grate! Thanks for making our life easier! (^_^)b
4 years, 3 months ago (2016-08-26 09:30:54 UTC) #6
tkent
Try bots found EphemeralRangeTest.* depended on the current output of Node stream printer. I updated ...
4 years, 3 months ago (2016-08-26 13:46:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282683002/20001
4 years, 3 months ago (2016-08-26 16:07:55 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 16:12:32 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 16:15:39 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d0702c27c930fc345318da2db6f33b2769bff5c
Cr-Commit-Position: refs/heads/master@{#414726}

Powered by Google App Engine
This is Rietveld 408576698