Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: content/renderer/media/android/stream_texture_wrapper_impl.h

Issue 2282633002: Integrate Surface requests with MediaPlayerRenderer (Closed)
Patch Set: Addressed last comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/stream_texture_wrapper_impl.h
diff --git a/content/renderer/media/android/stream_texture_wrapper_impl.h b/content/renderer/media/android/stream_texture_wrapper_impl.h
index 100aee27240d44443151c10f660f86c7d968e5a2..25f881ba5b03413cf0b72c888dea12106847e810 100644
--- a/content/renderer/media/android/stream_texture_wrapper_impl.h
+++ b/content/renderer/media/android/stream_texture_wrapper_impl.h
@@ -39,13 +39,6 @@ namespace content {
// - When the SurfaceTexture's OnFrameAvailable() callback is fired (and routed
// to the StreamTextureProxy living on the compositor thread), we notify
// |client_| that a new frame is available, via the DidReceiveFrame() callback.
-//
-// TODO(tguilbert): Register the underlying SurfaceTexture for retrieval in the
-// browser process. See crbug.com/627658.
-//
-// TODO(tguilbert): Change StreamTextureProxy's interface to accept a
-// base::Closure instead of requiring a VideoFrameProvider::Client, to simplify
-// the MediaPlayerRendererHost interface. See crbug.com/631178.
class CONTENT_EXPORT StreamTextureWrapperImpl
: public media::StreamTextureWrapper {
public:
@@ -78,6 +71,13 @@ class CONTENT_EXPORT StreamTextureWrapperImpl
// texture's changes are signalled via |client|'s DidReceiveFrame() callback.
scoped_refptr<media::VideoFrame> GetCurrentFrame() override;
+ // Sends the StreamTexture to the browser process, to fulfill the request
+ // identified by |request_token|.
+ // Uses the gpu::ScopedSurfaceRequestConduit to forward the underlying
+ // SurfaceTexture to the ScopedSurfaceRequestManager.
+ void ForwardStreamTextureForSurfaceRequest(
+ const base::UnguessableToken& request_token) override;
+
private:
StreamTextureWrapperImpl(
scoped_refptr<StreamTextureFactory> factory,

Powered by Google App Engine
This is Rietveld 408576698