Integrate Surface requests with MediaPlayerRenderer

content/browser/media/android/media_player_renderer.h

Index: content/browser/media/android/media_player_renderer.h
diff --git a/content/browser/media/android/media_player_renderer.h b/content/browser/media/android/media_player_renderer.h
index 42c2decfa8119366a351593b3c859e845644a24a..0460644da8f85a7dc8cd2dee111fba198b8443b2 100644
--- a/content/browser/media/android/media_player_renderer.h
+++ b/content/browser/media/android/media_player_renderer.h
@@ -8,6 +8,7 @@
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
+#include "base/unguessable_token.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/render_frame_host.h"
 #include "media/base/android/media_player_bridge.h"
@@ -85,10 +86,15 @@ class CONTENT_EXPORT MediaPlayerRenderer : public media::Renderer,
                    base::TimeDelta duration,
                    bool has_audio) override;
 
+  base::UnguessableToken InitiateScopedSurfaceRequest();

[liberato (no reviews please), 2016/09/21 14:33:28]

this could use some comments, including that it cancels any pending request.

[tguilbert, 2016/09/21 20:26:58]

Yes, MB!

+  void OnScopedSurfaceRequestCompleted(gl::ScopedJavaSurface surface);
+
  private:
   // Used when creating |media_player_|.
   void OnDecoderResourcesReleased(int player_id);
 
+  void CancelScopedSurfaceRequest();

[liberato (no reviews please), 2016/09/21 14:33:28]

perhaps comment that it's okay if there isn't any outstanding request.

[tguilbert, 2016/09/21 20:26:58]

Agreed.

+
   RenderFrameHost* render_frame_host_;
   media::RendererClient* renderer_client_;
 
@@ -102,6 +108,9 @@ class CONTENT_EXPORT MediaPlayerRenderer : public media::Renderer,
 
   gfx::Size video_size_;
 
+  base::UnguessableToken surface_request_token_;
+  bool is_waiting_for_surface_;
+
   std::unique_ptr<media::MediaResourceGetter> media_resource_getter_;
 
   // NOTE: Weak pointers must be invalidated before all other member variables.