Integrate Surface requests with MediaPlayerRenderer

media/mojo/clients/mojo_renderer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_MOJO_CLIENTS_MOJO_RENDERER_H_
 #define MEDIA_MOJO_CLIENTS_MOJO_RENDERER_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "base/time/default_tick_clock.h"
+#include "base/unguessable_token.h"
 #include "media/base/demuxer_stream.h"
 #include "media/base/renderer.h"
 #include "media/base/time_delta_interpolator.h"
 #include "media/mojo/interfaces/renderer.mojom.h"
 #include "mojo/public/cpp/bindings/binding.h"
 
 namespace base {
 class SingleThreadTaskRunner;
 }
 
@@ skipping 29 matching lines @@
   void SetCdm(CdmContext* cdm_context,
               const CdmAttachedCB& cdm_attached_cb) override;
   void Flush(const base::Closure& flush_cb) override;
   void StartPlayingFrom(base::TimeDelta time) override;
   void SetPlaybackRate(double playback_rate) override;
   void SetVolume(float volume) override;
   base::TimeDelta GetMediaTime() override;
   bool HasAudio() override;
   bool HasVideo() override;
 
+  using ReceiveSurfaceRequestTokenCB =
+      base::Callback<void(const base::Optional<base::UnguessableToken>&)>;
+
+  // Asks |remote_renderer_| to register a request in the browser's
+  // ScopedSurfaceRequestManager, and returns the request's token.
+  void InitiateScopedSurfaceRequest(
+      ReceiveSurfaceRequestTokenCB receive_request_token_cb);

[dcheng, 2016/09/26 17:41:51]

Callbacks are typically passed by const ref rather than by value (even though
copying it is relatively lightweight, it's not free).

(Strictly speaking, the preferred method going forward will be to pass by value
and use std::move() where transferring ownership, but that's not consistent with
how it's used in the codebase today. At some point, we're going to have a
migration plan and convert a lot of code to this new model though. Something to
think about...)

[tguilbert, 2016/09/26 19:46:35]

Ah yes! Done.

+
  private:
   // mojom::RendererClient implementation, dispatched on the
   // |task_runner_|.
   void OnTimeUpdate(base::TimeDelta time,
                     base::TimeDelta max_time,
                     base::TimeTicks capture_time) override;
   void OnBufferingStateChange(mojom::BufferingState state) override;
   void OnEnded() override;
   void OnError() override;
   void OnVideoNaturalSizeChange(const gfx::Size& size) override;
@@ skipping 77 matching lines @@
   mutable base::Lock lock_;
   base::DefaultTickClock media_clock_;
   media::TimeDeltaInterpolator media_time_interpolator_;
 
   DISALLOW_COPY_AND_ASSIGN(MojoRenderer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_MOJO_CLIENTS_MOJO_RENDERER_H_