components/password_manager/core/browser/password_form_manager_unittest.cc - Issue 228263004: Password manager internals page: Introduce logger in renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 228263004: Password manager internals page: Introduce logger in renderer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/common/autofill_messages.h ('K') | « components/password_manager/content/browser/content_password_manager_driver.cc ('k') | components/password_manager/core/browser/password_generation_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc

index 295be77173b7296b87e1ba7c54828fda989fc626..2a28b66518db32b8248dddace35f882d1934558f 100644

--- a/components/password_manager/core/browser/password_form_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc

@@ -14,9 +14,9 @@

#include "components/password_manager/core/browser/mock_password_store.h"

#include "components/password_manager/core/browser/password_form_manager.h"

#include "components/password_manager/core/browser/password_manager.h"

-#include "components/password_manager/core/browser/password_manager_client.h"

#include "components/password_manager/core/browser/password_manager_driver.h"

#include "components/password_manager/core/browser/password_store.h"

+#include "components/password_manager/core/browser/stub_password_manager_client.h"

#include "components/password_manager/core/browser/test_password_store.h"

#include "components/password_manager/core/common/password_manager_pref_names.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -60,7 +60,7 @@ class MockPasswordManagerDriver : public PasswordManagerDriver {

void(const std::vector<autofill::FormData>&));

};

-class TestPasswordManagerClient : public PasswordManagerClient {

+class TestPasswordManagerClient : public StubPasswordManagerClient {

public:

explicit TestPasswordManagerClient(PasswordStore* password_store)

: password_store_(password_store) {