Password manager internals page: Introduce logger in renderer

chrome/browser/password_manager/chrome_password_manager_client.cc

Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 586087a060e47b6ca2186f17a4aa987b5aedb617..618c4a1006d39c3f98efeda9d337d1beba7d2217 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -179,10 +179,12 @@ void ChromePasswordManagerClient::SetLogger(
 
 void ChromePasswordManagerClient::LogSavePasswordProgress(
     const std::string& text) {
-  if (logger_)
+  if (IsLoggingActive())
     logger_->LogSavePasswordProgress(text);
 }
 
+bool ChromePasswordManagerClient::IsLoggingActive() const { return logger_; }

[Ilya Sherman, 2014/04/09 21:10:08]

nit: clang-format is being updated to format this as three lines, rather than
one.  Please do so here ahead of that change landing upstream.

[Ilya Sherman, 2014/04/09 21:10:08]

nit: Please implement this as "return !!logger_", so that the returned value is
strictly |true| or |false|, rather than merely a bit pattern that is interpreted
as true.  In general, functions that promise to return a bool value should
return either 0 or 1.

[vabr (Chromium), 2014/04/10 08:51:25]

Thanks, that's good to know!
Done.

[vabr (Chromium), 2014/04/10 08:51:25]

I agree, and even the compiler of the win_chromium_compile_dbg bot flagged this
as an error.
Instead of prefixing "!!", I appended "!= NULL". I find the former dangerously
near to just "!", whereas the latter reads clearly. Let me know if that's not
OK.

+
 // static
 password_manager::PasswordGenerationManager*
 ChromePasswordManagerClient::GetGenerationManagerFromWebContents(