Password manager internals page: Introduce logger in renderer

components/autofill/content/renderer/renderer_save_password_progress_logger.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_BROWSER_SAVE_PASSWORD_PROGRESS_LOGGER_H_
+#define COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_BROWSER_SAVE_PASSWORD_PROGRESS_LOGGER_H_
+
+#include <string>
+
+#include "components/autofill/core/common/save_password_progress_logger.h"
+
+class PasswordManagerClient;
+
+namespace IPC {
+class Sender;
+}
+
+namespace autofill {
+
+// This is the SavePasswordProgressLogger specialization for the renderer code,
+// where the PasswordManagerClient can needs to be called over IPC.

[Ilya Sherman, 2014/04/09 21:10:08]

nit: "where the PasswordManagerClient can needs to be called over IPC." ->
something more like "which sends logs to the browser process over IPC."

[vabr (Chromium), 2014/04/10 08:51:25]

Done.

+class RendererSavePasswordProgressLogger
+    : public autofill::SavePasswordProgressLogger {
+ public:
+  RendererSavePasswordProgressLogger(IPC::Sender* sender, int routing_id);

[Ilya Sherman, 2014/04/09 21:10:08]

nit: Docs, please.

[vabr (Chromium), 2014/04/10 08:51:25]

Done.

+  virtual ~RendererSavePasswordProgressLogger();
+
+ protected:
+  // SavePasswordProgressLogger:
+  virtual void SendLog(const std::string& log) OVERRIDE;
+
+ private:
+  // Used by SendLog to send the IPC message with logs.
+  IPC::Sender* const sender_;

[Ilya Sherman, 2014/04/09 21:10:08]

nit: Please document lifetime expectations.

[vabr (Chromium), 2014/04/10 08:51:25]

Done.

+  const int routing_id_;
+
+  DISALLOW_COPY_AND_ASSIGN(RendererSavePasswordProgressLogger);
+};
+
+}  // namespace autofill
+
+#endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_RENDERER_BROWSER_SAVE_PASSWORD_PROGRESS_LOGGER_H_