Password manager internals page: Introduce logger in renderer

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
@@ skipping 161 matching lines @@
   // will leave the first without further updates, and the user likely confused.
   // TODO(vabr): For the reason above, before moving the internals page from
   // behind the flag, make sure to restrict the number of internals page
   // instances to 1 in normal profiles, and 0 in incognito.
   DCHECK(!logger || !logger_);
   logger_ = logger;
 }
 
 void ChromePasswordManagerClient::LogSavePasswordProgress(
     const std::string& text) {
-  if (logger_)
+  if (IsLoggingActive())
     logger_->LogSavePasswordProgress(text);
 }
 
+bool ChromePasswordManagerClient::IsLoggingActive() const { return logger_; }

[Ilya Sherman, 2014/04/09 21:10:08]

nit: clang-format is being updated to format this as three lines, rather than
one.  Please do so here ahead of that change landing upstream.

[Ilya Sherman, 2014/04/09 21:10:08]

nit: Please implement this as "return !!logger_", so that the returned value is
strictly |true| or |false|, rather than merely a bit pattern that is interpreted
as true.  In general, functions that promise to return a bool value should
return either 0 or 1.

[vabr (Chromium), 2014/04/10 08:51:25]

Thanks, that's good to know!
Done.

[vabr (Chromium), 2014/04/10 08:51:25]

I agree, and even the compiler of the win_chromium_compile_dbg bot flagged this
as an error.
Instead of prefixing "!!", I appended "!= NULL". I find the former dangerously
near to just "!", whereas the latter reads clearly. Let me know if that's not
OK.

+
 // static
 password_manager::PasswordGenerationManager*
 ChromePasswordManagerClient::GetGenerationManagerFromWebContents(
     content::WebContents* contents) {
   ChromePasswordManagerClient* client =
       ChromePasswordManagerClient::FromWebContents(contents);
   if (!client)
     return NULL;
   return client->GetDriver()->GetPasswordGenerationManager();
 }
@@ skipping 78 matching lines @@
           web_contents(),
           web_contents()->GetView()->GetNativeView());
   popup_controller_->Show(false /* display_password */);
 #endif  // #if defined(USE_AURA)
 }
 
 void ChromePasswordManagerClient::CommitFillPasswordForm(
     autofill::PasswordFormFillData* data) {
   driver_.FillPasswordForm(*data);
 }