[HBD] Update MD SiteSettingsHandler to support 3 modes.

[HBD] Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9ee7c7df4043a4b38ec4e95ecbc97dce7aad0e59
Cr-Commit-Position: refs/heads/master@{#414851}

[tommycli, 2016-08-25 22:54:00]

Description was changed from

==========
HTML5 By Default: Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
==========

to

==========
HTML5 By Default: Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-25 22:54:05]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 22:54:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-25 22:54:58]

tommycli@chromium.org changed reviewers:
+ finnur@chromium.org

[tommycli, 2016-08-25 22:54:59]

finnur: PTAL, thanks!

[commit-bot: I haz the power, 2016-08-26 00:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 00:25:10]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Finnur, 2016-08-26 11:11:44]

LGTM after the below is fixed.

https://codereview.chromium.org/2282603002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings_page/site_settings_page.js
(right):

https://codereview.chromium.org/2282603002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings_page/site_settings_page.js:59:
setting != settings.PermissionValues.BLOCK;
Please move this into a helper function in SiteSettingsBehavior (called
isCategoryEnabled or something) and use it here and in
site_settings_category.js.

[tommycli, 2016-08-26 16:52:16]

finnur: thanks!

https://codereview.chromium.org/2282603002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings_page/site_settings_page.js
(right):

https://codereview.chromium.org/2282603002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings_page/site_settings_page.js:59:
setting != settings.PermissionValues.BLOCK;
On 2016/08/26 11:11:44, Finnur wrote:
> Please move this into a helper function in SiteSettingsBehavior (called
> isCategoryEnabled or something) and use it here and in
> site_settings_category.js.

Done.

[tommycli, 2016-08-26 16:52:19]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-26 16:52:19]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/2282603002/#ps20001
(title: "fix comment")

[commit-bot: I haz the power, 2016-08-26 16:52:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 19:33:58]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tommycli, 2016-08-26 21:55:41]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-26 21:56:05]

Description was changed from

==========
HTML5 By Default: Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[HBD] Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-26 21:56:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 23:00:49]

Description was changed from

==========
[HBD] Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[HBD] Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-26 23:00:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 23:03:29]

Description was changed from

==========
[HBD] Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[HBD] Update MD SiteSettingsHandler to support 3 modes.

Plugins (soon to be called Flash) needs to support 3 modes in the
default content setting.

This patch updates the MD SiteSettingsHandler to return the default
content setting as a string (instead of just a boolean).

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9ee7c7df4043a4b38ec4e95ecbc97dce7aad0e59
Cr-Commit-Position: refs/heads/master@{#414851}
==========

[commit-bot: I haz the power, 2016-08-26 23:03:31]

Patchset 2 (id:??) landed as
https://crrev.com/9ee7c7df4043a4b38ec4e95ecbc97dce7aad0e59
Cr-Commit-Position: refs/heads/master@{#414851}