scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions.py - Issue 2282563004: Do not exclude the last revision in the range returned by gitiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions.py

Issue 2282563004: Do not exclude the last revision in the range returned by gitiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: typo Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json ('k') | scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions.py b/scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions.py

index 6a63b61f1de09c49231d574c92bb34c4f9bfed88..90d7f830113ec62bd8eeddf0966eb991301c91ea 100755

--- a/scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions.py

+++ b/scripts/slave/recipe_modules/auto_bisect/resources/fetch_intervening_revisions.py

@@ -42,8 +42,8 @@ def fetch_intervening_revisions(start, end, base_url):

Returns:

A list of pairs (commit hash, commit position), from earliest to latest,

- for all commits in between the two given commits, not including either

- of the given commits.

+ for all commits in between the two given commits, including the end commit

+ but not the start commit.

Raises:

urllib2.URLError: The request to gitiles failed.

@@ -53,7 +53,7 @@ def fetch_intervening_revisions(start, end, base_url):

revisions = _fetch_range_from_gitiles(start, end, base_url)

# The response from gitiles includes the end revision and is ordered

# from latest to earliest.

- return [_commit_pair(r) for r in reversed(revisions[1:])]

+ return [_commit_pair(r) for r in reversed(revisions)]

def _fetch_range_from_gitiles(start, end, base_url):